leahi-fwcommon

TestSupport.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 11
Last Commit: 24 Feb
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 02 Mar
4:41 pm

Sean Nash

Still need to range check the rate, reject if out of range, accept and assign if in range.

Still need to range check the rate, reject if out of range, accept and assign if in range.

4:26 pm

Sean Nash

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

I should have said "before test messages" instead of "first". But where you put them is fine so I will resolve.

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

2:53 pm

Vendor - TEL - Varshini Nagabooshanam

Assigned to local variable

Assigned to local variable

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

Updated to else part

Updated to else part

2:52 pm

Vendor - TEL - Varshini Nagabooshanam

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

I’ve updated the logic to explicitly set bloodPrimeResumeState when transitioning out of ramp (including flow change), so resume will always return to the correct prior state.

2:51 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

1:52 pm

Raghu Kallala

1:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring
LEAHI-DD-FIRMWARE-LDT-3514_Dialin config request to disable IOFP current monitoring
10:18 am

Sean Nash

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we a...

Actually, I think we should have the local variable to copy the payload into, then we should range check it (and potentially reject it if out of range), and if it is in range, only then should we assign new rate to your static variable.

10:15 am

Sean Nash

I think this can just be an else since resume is the only remaining possibility.

I think this can just be an else since resume is the only remaining possibility.

10:10 am

Sean Nash

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

Should we set resume state here? I know it's initialized to ramp state already, but in case we come back to ramp it may be safer to set it here.

9:59 am

Sean Nash

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

You moved it, but didn't change anything. The comment says it's a timer counter but the variable name suggests it is actually a flow rate. I want you to fix the comment.

9:56 am

Sean Nash

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

I think system messages (non Dialin (test) functions should come first in this table so that they are found faster.

Friday 27 Feb
12:01 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

12:01 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Removed and replaced

Removed and replaced

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Added

Added

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Assigned new variable

Assigned new variable

12:00 pm

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:59 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:59 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

11:59 am

Vendor - TEL - Varshini Nagabooshanam

Added

Added

11:59 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:59 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

11:59 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated