dd-firmware / firmware / App / Controllers

BalancingChamber.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 5
Last Commit: 03 Mar
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
2 hrs ago

Sean Nash

Use uppercase F

Use uppercase F

2 hrs ago

Sean Nash

Please declare local variables at top of scope (line 309 in this case).

Please declare local variables at top of scope (line 309 in this case).

Wednesday 25 Feb
3:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
1:47 pm

Sean Nash

DO NOT REVIEW - temporary branch to support new Diener 1000 pump changes. Will delete branch and CR when done.

DO NOT REVIEW - temporary branch to support new Diener 1000 pump changes. Will delete branch and CR when done.

1:35 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
LEAHI-DD-FIRMWARE-LDT-3103_implement closed loop control for d48 pump speed
Friday 13 Feb
9:25 am

Vinayakam Mani

Wednesday 11 Feb
5:05 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./BalancingChamber.h
  2. … 8 more files in changeset.
4:19 pm

Vendor - TEL - Sameer Poyil and Sean Nash

3:01 pm

Vinayakam Mani

Done.

Done.

2:49 pm

Vinayakam Mani

Updated.

Updated.

2:48 pm

Vendor - TEL - Sameer Poyil

copy paste error comment

copy paste error comment

2:39 pm

Sean Nash

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

Please convert bool expression to BOOL (TRUE or FALSE) before assigning (either in the expression with trinary or prior).

2:02 pm

Vinayakam Mani

Done

Done

2:02 pm

Vinayakam Mani

Done.

Done.

9:44 am

Dara Navaei

Tuesday 10 Feb
5:25 pm

Sean Nash

Add a comment to right listing math functions used.

Add a comment to right listing math functions used.

5:24 pm

Sean Nash

Remove blank line.

Remove blank line.

11:02 am

Vinayakam Mani

Looks crucible is not seeing those. let me check once with Dara.

Looks crucible is not seeing those. let me check once with Dara.

11:00 am

Vinayakam Mani

Done.

Done.

11:00 am

Vinayakam Mani

Updated.

Updated.

10:59 am

Vinayakam Mani

Updated

Updated

Monday 09 Feb
9:10 pm

Vendor - TEL - Sameer Poyil

seems to be old , need to merge the staging code

seems to be old , need to merge the staging code

9:07 pm

Vendor - TEL - Sameer Poyil

align the comment

align the comment

9:06 pm

Vendor - TEL - Sameer Poyil

complicated check should be replaced with boolean flag

complicated check should be replaced with boolean flag

7:45 pm

Vendor - TEL - Sameer Poyil

Variable name is not understood -temDataCollectionTimeInterval ?

Variable name is not understood -temDataCollectionTimeInterval ?

5:04 pm

Vinayakam Mani

Yes. updated.

Yes. updated.

Friday 06 Feb
2:17 pm

Sean Nash

So shouldn't we stop trimmer heater here then?

So shouldn't we stop trimmer heater here then?

Wednesday 04 Feb
3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done

Done

3:37 pm

Vinayakam Mani

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.

Since trimmer heater is enabled, no need of temp compensation. only for testing purposes, temp compensation is needed. Hence by default, temp compensation is disabled.