Activity dd-firmware/firmware/App/Modes/FPModes/FPOperationModes.c

6 hrs ago

Sean Nash

See my comment above. We should return BOOL so Dialin request can be ACK/NAK'd.

6 hrs ago

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request. We should do whatever is needed (if an...

No faults from Dialin commands - we never want Dialin to cause system to go to fault because it requested something invalid - we only NAK the invalid request.
We should do whatever is needed (if anything) to start the mode normally in an else.
And we should return TRUE/FALSE in these signal functions so that when it's called from Dialin msg handler, the msg handler can return ACK/NAK to Dialin if sub mode is invalid.

6 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

We shouldn't request op mode until we're sure we're happy with the whole thing. Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just re...

We shouldn't request op mode until we're sure we're happy with the whole thing.
Need to determine whether we are already in the op mode being requested. If so, no need to request it again - just request new sub mode if not already in it. If not, the currentSubMode checked below is not relevant (applies to current mode, not the requested mode) and we need to request new op mode and signal that new op mode that we will want to start in a specific sub mode.

6 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

Declarations should be at top of scope (right before memcpy).

6 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

Do we need this function? Can we do these 2 assignments in the Dialin msg handler function?

6 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

When moving this code to a function, the (requested) mode and sub mode should be passed in as parameters.

6 hrs ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

I don't think this code should be here. Should be moved to a function and called - probably not from here though. Can we call function with this code from the Dialin msg handler?

8 hrs ago

Raghu Kallala

More
Re: LEAHI-DD-FIRMWARE-LDT-3603-1
commented on review

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode? Sean NashMichael Garthwaite please confirm

Shall I add the SW_Fault as an else case if an invalid submode was requested for an opmode?
Sean Nash Michael Garthwaite please confirm

8 hrs ago

Raghu Kallala

I was thinking we could return BOOL to check if the request was successful, added it. But as you clarified the dialin response will only confirm the delivery of message successfully, I can change ...

I was thinking we could return BOOL to check if the request was successful, added it.

But as you clarified the dialin response will only confirm the delivery of message successfully, I can change all these signal functions to void
Thanks!

11 hrs ago