leahi-dialin / leahi_dialin / common

__init__.py

Clone Tools

Stats

Commits this week: 1
Total Committers: 4
Last Commit: 09 Mar
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Wednesday 04 Mar
12:46 pm

Dara Navaei

12:46 pm

Dara Navaei

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Wednesday 25 Feb
6:57 pm

Zoltan Miskolci

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

Options
    • -3
    • +3
    ./__init__.py
  2. … 60 more files in changeset.
Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Monday 09 Feb
10:34 am

Zoltan Miskolci

Saturday 07 Feb
4:46 pm

Dara Navaei

Friday 06 Feb
9:25 am

Zoltan Miskolci

We agreed to change back the enums into the static variation. Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic o...

We agreed to change back the enums into the static variation.
Why would that cover a class that has been implemented to mask the enums from direct access, so if they need to be changed to dynamic or renamed or anything, the other repositories that are using them through this class won't be affected or need any update.

Thursday 05 Feb
3:38 pm

Dara Navaei

Did we not decide to revert all the changes back and the redesign the whole concept again?

Did we not decide to revert all the changes back and the redesign the whole concept again?

3:35 pm

Behrouz NematiPour

Tuesday 03 Feb
3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:55 pm

Behrouz NematiPour

Look in the td_defs.py for the same comment.

Look in the td_defs.py for the same comment.

3:54 pm

Behrouz NematiPour

This design is incorrect, For common codes, a proxy or a wrapper class should have been implemented. We will keep it for now to unblock the rest of the team.

This design is incorrect,
For common codes, a proxy or a wrapper class should have been implemented.
We will keep it for now to unblock the rest of the team.

3:54 pm

Behrouz NematiPour

This is incorrect. We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use. We will keep it for now to unblock the rest of the...

This is incorrect.
We should not create many objects for all the Enum classes in an API, and we should not use memory that may not even be in use.
We will keep it for now to unblock the rest of the team.

2:27 pm

Zoltan Miskolci

When building locally without all the parameters the generated name throws an error during python pip install. So this ensures that if no parameter is added, it uses the default name which is compa...

When building locally without all the parameters the generated name throws an error during python pip install.
So this ensures that if no parameter is added, it uses the default name which is compatible with pip install.
The " -+. " sequence is throwing an error.

2:25 pm

Zoltan Miskolci

removed commented out line

removed commented out line

2:20 pm

Zoltan Miskolci

It's a class containing all the enums of the def file. Yes we need them as many other Framework and huge amount of code are using them.

It's a class containing all the enums of the def file.
Yes we need them as many other Framework and huge amount of code are using them.

2:20 pm

Zoltan Miskolci

Obviously not. You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

Obviously not.
You were reminding me about backwards compatibility. This variable and class ensures that even with this major refactor to the enum structure, the current codebase remains working.

2:15 pm

Zoltan Miskolci

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override. Updating an alias's value when adding new entries to the enum i...

Yes, they are aliases that are used for example in Dialin's temperature sensor module to decide which msg id to use for the override.
Updating an alias's value when adding new entries to the enum is easier then changing the last or first sensor type across Dialin modules, which could be forgotten or missed.

2:12 pm

Zoltan Miskolci

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

DialinEnum from_str function using it to match a strung to an enum member. Converting the string to enum for cleaner code in test cases.

2:10 pm

Zoltan Miskolci

Yes

Yes

Monday 02 Feb
4:50 pm

Dara Navaei

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

Not sure about this change. This script is used during the automated builds. Do you use this script anywhere else?

4:43 pm

Dara Navaei

Treatment Params have been removed from firmware.

Treatment Params have been removed from firmware.

4:38 pm

Dara Navaei

Are these part of FPTemperatureSensorName class?

Are these part of FPTemperatureSensorName class?