leahi-dialin / leahi_dialin / fp / modules

conductivity_sensors.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 4
Last Commit: 09 Mar
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Thursday 12 Feb
1:29 pm

Zoltan Miskolci

10:41 am

Michael Garthwaite and Raghu Kallala

9:48 am

Zoltan Miskolci

9:29 am

Zoltan Miskolci

Removed

Removed

9:23 am

Michael Garthwaite

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

Wednesday 11 Feb
11:33 am

Michael Garthwaite

10:10 am

Zoltan Miskolci

9:28 am

Dara Navaei

LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module
LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module
9:10 am

Michael Garthwaite

reverted handler to the original version. This was required to get a merge with develop to work

reverted handler to the original version. This was required to get a merge with develop to work

9:09 am

Michael Garthwaite

fixed.

fixed.

Tuesday 10 Feb
3:40 pm

Zoltan Miskolci

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete. Please re...

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

3:34 pm

Zoltan Miskolci

Duplicate, please remove

Duplicate, please remove

Monday 09 Feb
4:20 pm

Sean Nash

Thursday 05 Feb
11:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
Thursday 22 Jan
10:07 am

Zoltan Miskolci

Wednesday 21 Jan
12:35 pm

Sean Nash

11:08 am

Zoltan Miskolci

10:31 am

Raghu Kallala and Michael Garthwaite

9:47 am

Zoltan Miskolci

Tuesday 20 Jan
3:33 pm

Tiffany Mejia

10:14 am

Zoltan Miskolci

I added the unique decorator back, except for the few that have aliases

I added the unique decorator back, except for the few that have aliases

9:32 am

Zoltan Miskolci

Renamed, also flagged for future type change.

Renamed, also flagged for future type change.

Monday 19 Jan
11:52 am

Michael Garthwaite

"No one should interact with it or be aware of it's existence, so the name shouldn't matter." *it matters to those who read the code in inconsistent intervals ( like those who participate in code...

"No one should interact with it or be aware of it's existence, so the name shouldn't matter."

  • it matters to those who read the code in inconsistent intervals ( like those who participate in code review or teaching ).


"As we only have 2 version in test at the same time."

  • Currently. By summer, i'd expect dialin to be considering 1.0's, 1.9s, and 2.0s/DVTs.


We have the choice to handle the redesign effort then or now.


Edit:
Follow up comment.

Looking at the other files. Users of dialin will not be aware of existence, but developers of dialin will as it impacts the behavior of overrides like temp & pressure.

11:48 am

Michael Garthwaite

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique ke...

yes. that's the design consideration. Are we okay with our unit tests no longer checking for duplicate values? ( they will currently pass as i remember they expect an exception due to the unique keyword to fail. These will not trigger an exception ).