Activity leahi-dialin/leahi_dialin/td/modules/blood

10:46 am

Raghu Kallala

More
LEAHI-DIALIN-LDT-3557-1
finished reviewing

12:46 pm

Dara Navaei

More
LEAHI-DIALIN-LDT-2655-1
joined review

12:46 pm

Michael Garthwaite

More
LEAHI-DIALIN-LDT-3557-1
finished reviewing

3:28 pm

Michael Garthwaite

More
Re: LEAHI-DIALIN-LDT-3557-1
commented on review

Remove this extra line

6:57 pm

Zoltan Miskolci

More
20c821b
changed 61 files
LDT-3557-doc_header_for_vars, LDT-3607-command-to-home-td-valves-retur and 2 more LEAHI-DIALIN-LDT-3557-1

- Moved enum def class to proxy file - Added comments to module files - Removed test config TEST_CONFIG_DD_DRY_BICART_TEST

- -2
- +5
./blood_flow.py
- History
- Source
- Diff
./blood_flow.py
… 60 more files in changeset.

10:46 am

Dara Navaei

More
LEAHI-DIALIN-LDT-3557-1
started review

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables

9:22 am

Raghu Kallala

More
LEAHI-DIALIN-LDT-3160-1
finished reviewing

9:09 am

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the in...

This was made for the UI team, but it slowing down the init process and always throwing that error, that is not an error and not affecting the SW VV and SYS teams. So removing them to fasten the init process and to not have confusing messages

9:00 am

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-3160-1
commented on review

why are we passing this exception?

1:49 pm

Vinayakam Mani

More
LEAHI-DIALIN-LDT-3160-1
finished reviewing

1:47 pm

Vinayakam Mani

1:32 pm

Zoltan Miskolci

merged

1:32 pm

Zoltan Miskolci

renamed

1:32 pm

Zoltan Miskolci

renamed

1:32 pm

Zoltan Miskolci

Updated based on FW

1:19 pm

Raghu Kallala

More
Re: LEAHI-DIALIN-LDT-3160-1
commented on review

Here is the latest list from fw TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0, ///< Test configuration DD & FP enable Beta 1.0 hardware TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW, ///< Te...

Here is the latest list from fw

TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW = 0, ///< Test configuration DD & FP enable Beta 1.0 hardware
TEST_CONFIG_FIRST = TEST_CONFIG_DD_FP_ENABLE_BETA_1_0_HW, ///< Test configuration first configuration.
TEST_CONFIG_DD_DISABLE_BC_PRESSURE_ALARMS, ///< Test configuration DD disabling BC pressure alarms
TEST_CONFIG_DD_ENABLE_DRY_BICARB, ///< Test configuration DD to use dry bicarb
TEST_CONFIG_DD_ENABLE_4WIRE_RINSE_PUMP, ///< Test configuration DD enable 4-wire rinse pump.
TEST_CONFIG_FP_SKIP_PRE_GEN_FLUSH, ///< Test configuration FP skip pre-gen flush
TEST_CONFIG_DD_ENABLE_DIENER_1000_PUMP, ///< Test configuration to use diener 1000 pump for D48
TEST_CONFIG_DD_ENABLE_D79_PWM_CONTROL, ///< Test configuration to switch to PWM control for D79
TEST_CONFIG_DD_ENABLE_SPENT_CHAMBER_H_FILL, ///< Test configuration DD enable spent chamber H fill
TEST_CONFIG_DD_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable DD conductivity alarms
TEST_CONFIG_FP_DISABLE_CONDUCTIVITY_ALARMS, ///< Test configuration to disable FP conductivity alarms
TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL, ///< Test configuration to switch to open loop control for concentrate dosing
TEST_CONFIG_DD_ENABLE_UF_TEMP_COMPENSATION, ///< Test configuration for enabling UF temperature compensation
NUM_OF_TEST_CONFIGS ///< Number of test configuration.

11:49 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-3160-1
commented on review

Please sync all of these with Firmware order of definitions.

11:48 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-3160-1
commented on review

TEST_CONFIG_DD_ENABLE_UF_TEMP_COMP. by default, temp compensation is disabled.

11:43 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-3160-1
commented on review

TEST_CONFIG_DD_ENABLE_DOSING_OPEN_LOOP_CONTROL

11:41 am

Vinayakam Mani

More
Re: LEAHI-DIALIN-LDT-3160-1
commented on review

ENABLE_DRY_BICART_FILL vs ENABLE_LIQUID_BICARB => we can use only one of these. We can keep test config 2 ( may rename as ENABLE_DRY_BICARB) and 8 can be deleted.

11:40 am