dd-firmware / firmware / App / Modes

ModeGenDialysate.c

Clone Tools

Stats

Commits this week: 14
Total Committers: 12
Last Commit: 12 Mar
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vendor - TEL - Jashwant Gantyada

done changed it.

done changed it.

1 hr ago

Vinayakam Mani

Looks the fields are empty and misaligned. fill as needed.

Looks the fields are empty and misaligned. fill as needed.

3 hrs ago

Sean Nash

Remove extra blank line.

Remove extra blank line.

3 hrs ago

Sean Nash

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors? It looks kind of messy having separate handling for each sensor - can we conso...

Should we create a structure for these moving average filters and make an array of them based on enum of temp sensors?
It looks kind of messy having separate handling for each sensor - can we consolidate some of this code?

3 hrs ago

Sean Nash

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

Should we maybe just have a constant array of sample counts based on enum of temp sensors?

3 hrs ago

Sean Nash

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)? Controller properties already include a min and max field - can we use those?

Should min and max be properties of the controller instead of global (assumes all controllers will want same min/max)?
Controller properties already include a min and max field - can we use those?

3 hrs ago

Sean Nash

Remove blank line.

Remove blank line.

Thursday 12 Mar
10:01 pm

Vendor - TEL - Praneeth Bunne

9:59 pm

Vendor - TEL - Jashwant Gantyada

changed

changed

9:59 pm

Vendor - TEL - Jashwant Gantyada

removed from everywhere

removed from everywhere

9:58 pm

Vendor - TEL - Jashwant Gantyada

removed

removed

6:14 pm

Vinayakam Mani

Result is a BOOL variable, use FALSE.

Result is a BOOL variable, use FALSE.

5:24 pm

Vendor - TEL - Jashwant Gantyada

updated.

updated.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done.

done.

5:24 pm

Vendor - TEL - Jashwant Gantyada

done

done

5:24 pm

Vendor - TEL - Jashwant Gantyada

changed accordingly.

changed accordingly.

5:18 pm

Vinayakam Mani and Sean Nash

5:12 pm

Vendor - TEL - Praneeth Bunne

Fix getFreshDialPumpInitialRpm function name and brief inputs comment

Options
    • -9
    • +9
    ./ModeGenDialysate.c
4:53 pm

Sean Nash

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

I think the 2 initial rpm constants are inputs. The test config we would normally not include.

4:52 pm

Sean Nash

I think the word "Initial" should be in the function name (i.e. getFreshDialPumpInitialRpm).

I think the word "Initial" should be in the function name (i.e. getFreshDialPumpInitialRpm).

4:44 pm

Sean Nash

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

Why did this move? It needs to be in the nth row of the table (n = enum #) so that the enum will index to it in this table.

4:43 pm

Vinayakam Mani

4:42 pm

Vendor - TEL - Sameer Poyil

align

align

4:42 pm

Vendor - TEL - Sameer Poyil

align

align

4:41 pm

Vendor - TEL - Sameer Poyil

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

please do not use complicated statement in if condition. take out this logic before if condition and use BOOL variable.

4:38 pm

Vendor - TEL - Sameer Poyil

comment should start with capital letter

comment should start with capital letter

4:36 pm

Vendor - TEL - Jashwant Gantyada

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.

I see the TODO in staging and also, I see it in my branch, but I don't see it on this review.

4:34 pm

Vendor - TEL - Jashwant Gantyada

done

done

4:34 pm

Vendor - TEL - Jashwant Gantyada

added

added

4:34 pm

Vendor - TEL - Jashwant Gantyada

declared a fill timeout alarm

declared a fill timeout alarm