dd-firmware / firmware / App / Modes

ModeGenDialysate.c

Clone Tools

Stats

Commits this week: 8
Total Committers: 13
Last Commit: 30 Mar
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 03 Apr
3:35 pm

Vinayakam Mani

Done.

Done.

3:34 pm

Vinayakam Mani

Done

Done

3:34 pm

Vinayakam Mani

Done.

Done.

1:20 pm

Sean Nash

Same comment.

Same comment.

1:19 pm

Sean Nash

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

Having much larger P coeff is likely to cause a lot of oscillations and very slow to get to stable target.

1:14 pm

Sean Nash

Input is d78TempAvgC

Input is d78TempAvgC

1:13 pm

Sean Nash

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

I don't think these min/max (for control output in output units i.e. PWM) are appropriate for limiting maximum error sum step size (error is in feedback/target units i.e. RPM).

1:11 pm

Sean Nash

Not sure these min/max are right here either.

Not sure these min/max are right here either.

8:34 am

Sean Nash

Thursday 02 Apr
3:43 pm

Vinayakam Mani

Done.

Done.

3:43 pm

Vinayakam Mani

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

Just following the current style of code implementation to keep it uniform. These defines are temporary and will be removed.

3:40 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:28 pm

Vinayakam Mani

Done.

Done.

3:28 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

3:27 pm

Vinayakam Mani

Done.

Done.

10:35 am

Vinayakam Mani

9:52 am

Vendor - TEL - Jashwant Gantyada

updated.

updated.

9:52 am

Vendor - TEL - Jashwant Gantyada

updated.

updated.

9:04 am

Sean Nash

9:04 am

Sean Nash

Reverse order of comparison

Reverse order of comparison

9:03 am

Sean Nash

Reverse order of comparison.

Reverse order of comparison.

9:02 am

Sean Nash

Reverse order of comparison.

Reverse order of comparison.

9:01 am

Sean Nash

Reverse order of comparison.

Reverse order of comparison.

Wednesday 01 Apr
2:36 pm

Vinayakam Mani

Done.

Done.

11:13 am

Sean Nash

More implied boolean assignments.

More implied boolean assignments.

11:13 am

Sean Nash

Implied boolean assignment. Use ternary operator to assign TRUE or FALSE explicitly or don't initialize in declaration and use if else below to assign.

Implied boolean assignment. Use ternary operator to assign TRUE or FALSE explicitly or don't initialize in declaration and use if else below to assign.

Monday 30 Mar
10:17 am

Dara Navaei