dd-firmware / firmware / App / Controllers

ROPump.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 5
Last Commit: 30 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 24 Jun
6:36 am

Raghu Kallala

Thursday 28 May
1:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:
Wednesday 06 May
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Sunday 26 Apr
2:17 pm

Sean Nash

Add a blank line before group end marker.

Add a blank line before group end marker.

1:40 pm

Sean Nash

Are we only doing DD messages? And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal ...

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.

Thursday 16 Apr
8:24 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./ROPump.c
  2. … 5 more files in changeset.
8:15 am

Michael Garthwaite

Wednesday 15 Apr
5:31 pm

Sean Nash and Vinayakam Mani

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am

Michael Garthwaite

nope. removed.

nope. removed.

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

9:52 am

Michael Garthwaite

fixed

fixed

7:52 am

Michael Garthwaite

LDT-3218: code review comments

Options
    • -0
    • +1
    ./ROPump.c
  2. … 3 more files in changeset.
Tuesday 14 Apr
2:08 pm

Sean Nash

Add blank line before return.

Add blank line before return.

2:07 pm

Sean Nash

Add blank line after declarations.

Add blank line after declarations.

2:05 pm

Sean Nash

Why U32? Why not RECOVER_STATE_T?

Why U32? Why not RECOVER_STATE_T?

2:04 pm

Sean Nash

Lower case x

Lower case x

2:02 pm

Sean Nash

Is blood flow in need of a PID controller too?

Is blood flow in need of a PID controller too?

11:25 am

Michael Garthwaite

LDT-3218: fixed valve config call

Options
    • -1
    • +2
    ./ROPump.c
  2. … 1 more file in changeset.
Monday 06 Apr
7:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
LEAHI-DD-FIRMWARE-LDT-3735_System Data and Logs - DD - Non-Volatile Memory - 04: DEV - Feature Implementation
Thursday 26 Mar
6:27 pm

Michael Garthwaite

LDT-3218: updated equation for medium recovery

Options
    • -2
    • +2
    ./ROPump.c
4:23 pm

Michael Garthwaite

LDT-3218: slopes and intercepts per recovery config. removed recirculation for no recovery.

Options
    • -15
    • +32
    ./ROPump.c
  2. … 2 more files in changeset.
12:22 pm

Michael Garthwaite

LDT-3218: integration fixes.

Options
    • -0
    • +1
    ./ROPump.c
  2. … 1 more file in changeset.
12:12 pm

Michael Garthwaite

LDT-3218: set valve config override and supporting functions. P6 no longer opens for no recovery valve config. Implemented PID controls for RO pump.

Options
    • -12
    • +17
    ./ROPump.c
  2. … 4 more files in changeset.
Wednesday 25 Mar
11:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
LEAHI-DD-FIRMWARE-LDT-3218_Update IOFP permeate target flow rate to 800 mL/min (and flow control as needed)
11:11 am

Michael Garthwaite

LDT-3218: control coefficients for beta 2.0

Options
    • -2
    • +2
    ./ROPump.c
Friday 23 Jan
1:07 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ROPump.c