Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Substitution pump

Substitution pump

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

Missing comment.

Missing comment.

update comment. next one as well.

update comment. next one as well.

blank line after the banner and maintain alphabetical order of include files.

blank line after the banner and maintain alphabetical order of include files.

LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DD-FIRMWARE-LDT-4001_HDF - FW Implementation - 2/4:
Done.

Done.

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

Done.

Done.

Done.

Done.

Should we set this flag to FALSE at top of loop?

Should we set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

Update comment.

Update comment.

Is this eventually going to be d1Temp?

Is this eventually going to be d1Temp?

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
a time out for decaying D66 pressure to 3 PSI after D65 closed

a time out for decaying D66 pressure to 3 PSI after D65 closed

remove space after <= and add space end of function call.

remove space after <= and add space end of function call.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

Is this time out after D80 opening or D65 closing state? if it is D65 closed, you need to start the timer after D65 closing.

if we are not checking level, this can be removed and function name also can be updated accordingly.

if we are not checking level, this can be removed and function name also can be updated accordingly.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

Is this a TODO? If so, add TODO to the comment and maybe be a little more descriptive of what needs to be done.

can we get 'runPIController' inside deadband control check?

can we get 'runPIController' inside deadband control check?