dd-firmware / firmware / App

DDCommon.h

Clone Tools

Stats

Commits this week: 9
Total Committers: 9
Last Commit: 28 May
Commits this week: 9

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

1 hr ago

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

5 hrs ago

Vinayakam Mani

Done.

Done.

5 hrs ago

Vendor - TEL - Jashwant Gantyada

5 hrs ago

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

6 hrs ago

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

6 hrs ago

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

6 hrs ago

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

6 hrs ago

Vinayakam Mani

Done.

Done.

6 hrs ago

Vinayakam Mani

Done.

Done.

Wednesday 27 May
3:43 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
Friday 22 May
11:18 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./DDCommon.h
  2. … 18 more files in changeset.
11:11 am

Vendor - TEL - Jashwant Gantyada

10:50 am

Sean Nash and Vinayakam Mani

9:05 am

Vendor - TEL - Jashwant Gantyada

Merge branch 'staging' into feature/LDT-3963-dialysate-flow-rate---fw-implem

Options
    • -1
    • +1
    ./DDCommon.h
  2. … 1 more file in changeset.
Thursday 21 May
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments and restored the fault mode transition

Options
    • -8
    • +8
    ./DDCommon.h
  2. … 9 more files in changeset.
Wednesday 20 May
10:39 am

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

11:26 pm

Sean Nash

Details looks weird. Where is inputs and outputs like other function headers?

Details looks weird. Where is inputs and outputs like other function headers?

11:19 pm

Sean Nash

Add a blank line after banner.

Add a blank line after banner.

11:19 pm

Sean Nash

Please restore before you merge to staging.

Please restore before you merge to staging.

11:16 pm

Sean Nash

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

If I'm reading this right, we're saying that if bad CRC alarm is NOT enabled, initialize the alarm? That seems backward.

11:14 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.

11:13 pm

Sean Nash

Same comments as ENABLE_ALARM_1 above.

Same comments as ENABLE_ALARM_1 above.