Activity td-firmware/firmware/App/Modes/ModePreTreat.h

Tree
Accordion

Stats

Commits this week: 1

Total Committers:	4
Last Commit:	11 May
Commits this week:	1

Lines of code count not available

Commit Activity

last updated a few minutes ago

Constraints

Constraints: committers

Committer:

Log Comment:

Constraints: files

File Extension:

File Name:

Constraints: dates

Start Date:

Start Date:

End Date:

End Date:

Today

7 hrs ago

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

7 hrs ago

Sean Nash and Vendor - TEL - Arpita Srivastava

More
LEAHI-TD-FIRMWARE-LDT-1886-2
resumed reviewing

Tuesday 19 May

5:39 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-2240-1
commented on review

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-2240-1
commented on review

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

This merge conflict is still unresolved.

This merge conflict is still unresolved.

3:35 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

leak in the comment section.

leak in the comment section.

3:34 pm

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

Where is alarm 191..203?

Where is alarm 191..203?

Monday 18 May

9:45 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

9:44 am

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

please add bpLeftHomeTimerCounter to inputs and outputs.

please add bpLeftHomeTimerCounter to inputs and outputs.

Friday 15 May

9:52 am

Vendor - TEL - Varshini Nagabooshanam

I missed updating this earlier, I’ll push the updated code.

I missed updating this earlier, I’ll push the updated code.

9:19 am

Sean Nash

Can't have 3 values. Maximum 2 values allowed.

Can't have 3 values. Maximum 2 values allowed.

Wednesday 13 May

10:48 am

Vendor - TEL - Varshini Nagabooshanam

Removedd

Removedd

10:44 am

Vendor - TEL - Varshini Nagabooshanam

added

added

Tuesday 12 May

1:58 pm

Vendor - TEL - Arpita Srivastava

More
Re: LEAHI-TD-FIRMWARE-LDT-1886-2
commented on review

We only add File level or global variables in Inputs and Outputs. Please remove functions from the input section of this and other functions.

We only add File level or global variables in Inputs and Outputs.
Please remove functions from the input section of this and other functions.

9:40 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

Monday 11 May

10:30 am

Dara Navaei

More
da59fa4
changed 12 files
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 5 more LEAHI-TD-FIRMWARE-LDT-2240-1 LEAHI-TD-FIRMWARE-LDT-1886-2 LEAHI-TD-FIRMWARE-LDT-3505-1 LEAHI-TD-FIRMWARE-LDT-3259-1

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -2
- +2
./ModePreTreat.h
- History
- Source
- Diff
./ModePreTreat.h
… 11 more files in changeset.

9:42 am

Raghu Kallala

9:07 am

Michael Garthwaite and Sean Nash

More
LEAHI-TD-FIRMWARE-LDT-4188-1
finished reviewing

Friday 08 May

11:17 am

Vendor - TEL - Varshini Nagabooshanam

More
LEAHI-TD-FIRMWARE-LDT-1886-2
resumed reviewing

8:51 am

Raghu Kallala

More
b7ab133
changed 1 file
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 7 more LEAHI-TD-FIRMWARE-LDT-4188-1

LDT-4188 updated comments and added space at end of file

- -1
- +2
./ModePreTreat.h
- History
- Source
- Diff
./ModePreTreat.h

Thursday 07 May

3:20 pm

Raghu Kallala

More
835a6bf
changed 3 files
LDT-1886-blood-set-auto-load-and-auto-ej, LDT-2240-disposable-tube-set-self-test and 7 more LEAHI-TD-FIRMWARE-LDT-4188-1

LDt-4188 added alarmaction to pre treatment

- -1
- +1
./ModePreTreat.h
- History
- Source
- Diff
./ModePreTreat.h
… 2 more files in changeset.

11:12 am

Sean Nash

More
Re: LEAHI-TD-FIRMWARE-LDT-2240-1
commented on review

Remove start state.

Remove start state.

10:30 am

Vendor - TEL - Varshini Nagabooshanam

Updated

Updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

updated

updated

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Yes, removed

Yes, removed

10:29 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

yes, removed

yes, removed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Changed

Changed

10:28 am

Vendor - TEL - Varshini Nagabooshanam

Removed

Removed

Atlassian Fisheye Git analysis with Crucible code review. (Version:4.8.14 Build:20240111091859 2024-01-11 09:20) - Administration - Page generated 2026-05-20 23:22 -0700