leahi-fwcommon

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

I thought this was a TEST_CONFIG thing. We aren't doing s/w config status, so maybe we should convert it to a TEST_CONFIG.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Let's hard code for time being with a TODO comment. I don't want alarm to be a problem.

Use OVERRIDE_RESET for .override instead of 0.

Use OVERRIDE_RESET for .override instead of 0.

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

Is this the right time to zero this volume?

Is this the right time to zero this volume?

update total volume too?

update total volume too?

maybe use target rate for both.

maybe use target rate for both.

Use #define for array size.

Use #define for array size.

Make the 6 a #define

Make the 6 a #define

only 1 return statement

only 1 return statement

remove comma

remove comma

return FALSE on else

return FALSE on else

signal functions should return BOOL.

signal functions should return BOOL.

Move up with rest

Move up with rest

Move this function to your service.

Move this function to your service.

Add HDF state too

Add HDF state too

Not needed.

Not needed.

Should always exec your bolus sm.

Should always exec your bolus sm.

Keep 2 blank lines before banner

Keep 2 blank lines before banner

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

Add fluid bolus state

FLUID_BOLUS_CMD_EVENT

FLUID_BOLUS_CMD_EVENT

LDT-4013: Add active alarm countmethod and substitution rate payload

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

Remove this blank line.

Remove this blank line.

Align comment.

Align comment.

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.