leahi-fwcommon

Clone Tools

Stats

Commits this week: 6
Total Committers: 13
Last Commit: 09:58
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vendor - TEL - Jashwant Gantyada

align indentation, same for line 338 as well.

align indentation, same for line 338 as well.

1 hr ago

Vendor - TEL - Arpita Srivastava

Yes. Otherwise, we will have to hard code the calibration record for the time being.

Yes.
Otherwise, we will have to hard code the calibration record for the time being.

1 hr ago

Vendor - TEL - Arpita Srivastava

The function getSoftwareConfigStatus() is also part of NVM module. Moreover, we are planning to remove this function when NVM will be implemented. So, we will have to perform a cleanup and remove a...

The function getSoftwareConfigStatus() is also part of NVM module.
Moreover, we are planning to remove this function when NVM will be implemented.
So, we will have to perform a cleanup and remove all similar calls that have been currently commented out in other files as well like AirTrap.c, BloodFlow.c, etc.

3 hrs ago

Sean Nash

Is this the right time to zero this volume?

Is this the right time to zero this volume?

3 hrs ago

Sean Nash

update total volume too?

update total volume too?

3 hrs ago

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

4 hrs ago

Sean Nash

Use #define for array size.

Use #define for array size.

4 hrs ago

Sean Nash

Make the 6 a #define

Make the 6 a #define

4 hrs ago

Sean Nash

only 1 return statement

only 1 return statement

4 hrs ago

Sean Nash

remove comma

remove comma

4 hrs ago

Sean Nash

return FALSE on else

return FALSE on else

4 hrs ago

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

4 hrs ago

Sean Nash

Move up with rest

Move up with rest

4 hrs ago

Sean Nash

Move this function to your service.

Move this function to your service.

4 hrs ago

Sean Nash

Add HDF state too

Add HDF state too

4 hrs ago

Sean Nash

Not needed.

Not needed.

4 hrs ago

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

4 hrs ago

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

4 hrs ago

Sean Nash

Add fluid bolus state

Add fluid bolus state

4 hrs ago

Sean Nash

Add fluid bolus state

Add fluid bolus state

4 hrs ago

Sean Nash

FLUID_BOLUS_CMD_EVENT

FLUID_BOLUS_CMD_EVENT

5 hrs ago

Vendor - TEL - Praneeth Bunne

LDT-4013: Add active alarm countmethod and substitution rate payload

Options
    • -0
    • +23
    /AlarmMgmt.c
    • -0
    • +2
    /AlarmMgmt.h
    • -0
    • +1
    /MessagePayloads.h
Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

2:33 pm

Sean Nash

2:30 pm

Sean Nash

Align comment.

Align comment.

2:24 pm

Sean Nash

Keep 2 blank lines above banner.

Keep 2 blank lines above banner.

2:20 pm

Sean Nash

Should this line be un-commented?

Should this line be un-commented?

2:19 pm

Sean Nash

So we are going to fail this test until calibration record is ready?

So we are going to fail this test until calibration record is ready?

2:16 pm

Sean Nash

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).

In Leahi, we want to do all initialization in the init function instead of here at declaration (see Bubble.c for example).