DDDefs.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
fix the id back to 255 in the struct

fix the id back to 255 in the struct

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

close D80, D64, D14?

close D80, D64, D14?

D80 : open, D65: Close?

D80 : open, D65: Close?

LDT-4024 base implementation for heat disinfection

  1. … 1 more file in changeset.
This isn't right. Look at staging for correct code.

This isn't right. Look at staging for correct code.

I'm seeing a lot of magic numbers. We should have #defines for these values.

I'm seeing a lot of magic numbers. We should have #defines for these values.

Add doxygen comments to right.

Add doxygen comments to right.

LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
Not needed? Add another BOOL for disinfection option received.

Not needed? Add another BOOL for disinfection option received.

Initialize this.

Initialize this.

Remove TODO

Remove TODO

Remove disable of ejector motor.

Remove disable of ejector motor.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Just move msg handlers from Messaging to here so you don't need a signal.

Just move msg handlers from Messaging to here so you don't need a signal.

Move to .c file to make private.

Move to .c file to make private.

Not needed.

Not needed.

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

Missing heat citric

Missing heat citric

Put back to reserved

Put back to reserved

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

The current implementation and OR and AND logic is a problem , We need a better logic here. for the time being OR is better so that it won't suck up till pressure drops to 4PSI

removed

removed

updated

updated