td-firmware / firmware / App / Modes

ModePreTreat.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 4
Last Commit: 29 May
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 01 Jun
10:28 am

Vendor - TEL - Jashwant Gantyada

where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

10:25 am

Vendor - TEL - Jashwant Gantyada

do we need this block?

do we need this block?

10:09 am

Vinayakam Mani

update the comment as required: ml or L?

update the comment as required: ml or L?

10:00 am

Sean Nash

10:00 am

Sean Nash

9:22 am

Sean Nash

Friday 29 May
2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

Friday 22 May
3:39 pm

Vendor - TEL - Praneeth Bunne

1:31 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

11:47 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ModePreTreat.h
  2. … 14 more files in changeset.
Wednesday 20 May
3:49 pm

Vendor - TEL - Arpita Srivastava

We can rename priorState to previousInstallState. Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

We can rename priorState to previousInstallState.
Also, it should be declared as a static variable to be able to retain previousState value when the control goes out of the function.

12:09 pm

Sean Nash

maybe use target rate for both.

maybe use target rate for both.

11:41 am

Sean Nash

Use #define for array size.

Use #define for array size.

11:40 am

Sean Nash

Make the 6 a #define

Make the 6 a #define

11:39 am

Sean Nash

only 1 return statement

only 1 return statement

11:35 am

Sean Nash

remove comma

remove comma

11:24 am

Sean Nash

signal functions should return BOOL.

signal functions should return BOOL.

11:20 am

Sean Nash

Move up with rest

Move up with rest

11:17 am

Sean Nash

Move this function to your service.

Move this function to your service.

11:09 am

Sean Nash

Not needed.

Not needed.

11:06 am

Sean Nash

Should always exec your bolus sm.

Should always exec your bolus sm.

11:01 am

Sean Nash

Keep 2 blank lines before banner

Keep 2 blank lines before banner

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

10:59 am

Sean Nash

Add fluid bolus state

Add fluid bolus state

Tuesday 19 May
5:39 pm

Sean Nash

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

These alarms are in the wrong place. Their enums are 187..199. So they should be at the very end of this table, not here near the beginning.

5:37 pm

Sean Nash

Remove this blank line.

Remove this blank line.

3:37 pm

Vendor - TEL - Arpita Srivastava

There is still merge conflict? Please resolve merge conflict and build the code in your local before pushing.

There is still merge conflict?
Please resolve merge conflict and build the code in your local before pushing.

3:35 pm

Sean Nash

This merge conflict is still unresolved.

This merge conflict is still unresolved.