td-firmware / firmware / App / Services

TxParams.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 6
Last Commit: 15 Jul
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Wednesday 15 Jul
11:59 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./TxParams.h
  2. … 8 more files in changeset.
9:15 am

Vendor - TEL - Arpita Srivastava

Tuesday 14 Jul
5:55 pm

Sean Nash

9:26 am

Vendor - TEL - Arpita Srivastava

currentInstallState is an input.

currentInstallState is an input.

9:23 am

Vendor - TEL - Arpita Srivastava

Do we need doxygen comments for static function declarations? We will have a header in the definition.

Do we need doxygen comments for static function declarations?
We will have a header in the definition.

9:18 am

Vendor - TEL - Arpita Srivastava

AirPump.h should be above AirTrap.h

AirPump.h should be above AirTrap.h

Tuesday 07 Jul
3:16 pm

Sean Nash

9:38 am

Vendor - TEL - Vijay Pamula

LDT-4028:Addresses Review Comments for Install State

Options
    • -1
    • +1
    ./TxParams.h
  2. … 2 more files in changeset.
Wednesday 01 Jul
10:21 am

Sean Nash

Remove extra ;

Remove extra ;

10:18 am

Sean Nash

Can we align comments?

Can we align comments?

10:01 am

Sean Nash

Missing pinch valves (H1 and H19).

Missing pinch valves (H1 and H19).

9:59 am

Sean Nash

Remove this blank line.

Remove this blank line.

Friday 26 Jun
9:51 am

Vendor - TEL - Vijay Pamula

LDT-4028:Addressed code review commens for Pre-Tx Install State

Options
    • -2
    • +2
    ./TxParams.h
  2. … 8 more files in changeset.
Wednesday 24 Jun
2:42 pm

Vendor - TEL - Arpita Srivastava

please add message id.

please add message id.

2:34 pm

Sean Nash

We should set all TD actuators here, not just blood pump.

We should set all TD actuators here, not just blood pump.

1:14 pm

Sean Nash

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

I think we should accept this as long as we're in pre-tx: install state. User might confirm before auto-load finishes and that's ok.

1:00 pm

Sean Nash

Change "SetupConnection" to "SetupTubingSetConnection"

Change "SetupConnection" to "SetupTubingSetConnection"

12:59 pm

Sean Nash

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

Recommend changing "SETUP_CONNECTION" to "SETUP_TUBING_SET_CONNECTIONS" in these 2 msg ID names.

6:36 am

Raghu Kallala

Wednesday 17 Jun
12:04 pm

Vendor - TEL - Vijay Pamula

Monday 15 Jun
2:32 pm

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
LEAHI-TD-FIRMWARE-LDT-4028_Pre-Treatment - FW Implementation - 3/6:
Friday 12 Jun
2:26 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./TxParams.h
  2. … 2 more files in changeset.
2:01 pm

Vendor - TEL - Arpita Srivastava and Sean Nash

Thursday 11 Jun
10:29 pm

Vendor - TEL - Praneeth Bunne

Wednesday 10 Jun
3:24 pm

Vendor - TEL - Vijay Pamula

Tuesday 09 Jun
10:19 am

Vendor - TEL - Arpita Srivastava

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input. Then you will not need all thes...

How about instead of taking U32 minValue and U32 maxValue as input, we take SYS_CONFIG_TREATMENT_PARAM_T minValue and SYS_CONFIG_TREATMENT_PARAM_T maxValue as input.
Then you will not need all these repetitive functions:
isSystolicBpLowAlarmLimitValid
isSystolicBpHighAlarmLimitValid
isHeartRateLowAlarmLimitValid
isHeartRateHighAlarmLimitValid

Similarly, you can create another function with input as TREATMENT_PARAM_T minValue and TREATMENT_PARAM_T maxValue for isVitalsMeasurementIntervalValid()

10:05 am

Vendor - TEL - Arpita Srivastava

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Should the msg id be: MSG_ID_TD_VITALS_ADJUSTMENT_RESPONSE?

Monday 08 Jun
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).