dd-firmware / firmware / App / Controllers

Ultrafiltration.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 6
Last Commit: 25 Jun
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Vinayakam Mani

1 hr ago

Vendor - TEL - Jashwant Gantyada

updated

updated

2 hrs ago

Sean Nash

balancingError is an input.

balancingError is an input.

Tuesday 30 Jun
4:15 pm

Vendor - TEL - Arpita Srivastava

Add previousHeaterState to input and output

Add previousHeaterState to input and output

4:13 pm

Vendor - TEL - Arpita Srivastava

add prevDryBicartState to input and output.

add prevDryBicartState to input and output.

4:11 pm

Vendor - TEL - Arpita Srivastava

Add prevBalChamberState to input and output

Add prevBalChamberState to input and output

4:09 pm

Vendor - TEL - Arpita Srivastava

Add isBalChamberSwitchingActive to input

Add isBalChamberSwitchingActive to input

3:56 pm

Sean Nash

yes

yes

3:56 pm

Sean Nash

yes

yes

3:55 pm

Sean Nash

yes

yes

2:40 pm

Vinayakam Mani

Align it with declration.

Align it with declration.

2:39 pm

Vinayakam Mani

Add comments.

Add comments.

Wednesday 24 Jun
6:36 am

Raghu Kallala

Monday 22 Jun
5:06 pm

Vinayakam Mani

Revise the code per new UF implementation.

Revise the code per new UF implementation.

5:03 pm

Vinayakam Mani

looks like this function sets the actuators every time when the same state is set by TD?

looks like this function sets the actuators every time when the same state is set by TD?

4:33 pm

Vinayakam Mani

Remove Dialysate from the handler name.

Remove Dialysate from the handler name.

1:29 pm

Vinayakam Mani

Add Comment. Rename macro as UF_VOL_ML_PER_TASK_INTERVAL

Add Comment. Rename macro as UF_VOL_ML_PER_TASK_INTERVAL

Thursday 18 Jun
1:53 pm

Vinayakam Mani

Looks On event handled later. One event should be fine for On condtion.

Looks On event handled later. One event should be fine for On condtion.

1:51 pm

Vinayakam Mani

Space after 0

Space after 0

1:48 pm

Vinayakam Mani

prevDryBicartState

prevDryBicartState

1:46 pm

Vinayakam Mani

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

I guess, you should use OnOff status as second argument, since isBalChamberSwitchingActive varirable set after this function, it won't have latest status.

1:31 pm

Vinayakam Mani

prevBalChamberState?

prevBalChamberState?

10:21 am

Vendor - TEL - Arpita Srivastava

Should we also send an event when we start the heater?

Should we also send an event when we start the heater?

10:11 am

Vendor - TEL - Arpita Srivastava

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line. The code will still work if we remove the first condition c...

We can combine all these condition checks in a single if() at line 423 separated by || and then we can send the event change in one line.
The code will still work if we remove the first condition check for prevState from line 427 and 431

Friday 12 Jun
9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Monday 08 Jun
6:19 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change
LEAHI-DD-FIRMWARE-LDT-4539_Provide event on Service state change
9:21 am

Vendor - TEL - Jashwant Gantyada

comments start's with uppercase?

comments start's with uppercase?