leahi-fwcommon

PIControllers.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 9
Last Commit: 17 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Jul
1:07 pm

Sean Nash

I would keep blank line between library includes and regular includes.

I would keep blank line between library includes and regular includes.

1:05 pm

Sean Nash

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added. I think you should just remove this new alarm 196...

We can't have 2 alarms with ID 196. The enum only has the empty saline bag alarm. Looks like alarm 197 is duplicate of this 196 alarm you've added.
I think you should just remove this new alarm 196 that you've added here.

Tuesday 30 Jun
1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

1:23 pm

Sean Nash

Fix merge conflict stuff here.

Fix merge conflict stuff here.

Friday 12 Jun
5:40 pm

Vinayakam Mani

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

5:39 pm

Vinayakam Mani

Input : Blood pump door status?

Input : Blood pump door status?

5:27 pm

Vinayakam Mani

To be restored?

To be restored?

5:24 pm

Vinayakam Mani

Are these being initialized in the init function?

Are these being initialized in the init function?

5:16 pm

Vinayakam Mani

Need to resolve the merge issues?

Need to resolve the merge issues?

Wednesday 03 Jun
9:51 am

Sean Nash

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD...

It looks like you have this as a T/F response from UI. UI should not be determining whether the modality matches - that's our job. UI should be telling us which type of tubing set was installed (HD or HDF type). Then when we get this response msg from UI, we will compare the type to the user selected modality (from TxParams) to see if it matches.

9:48 am

Sean Nash

Add doxygen comments to the right of each structure field.

Add doxygen comments to the right of each structure field.

9:47 am

Sean Nash

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

Why is this commented out? We will get stuck in this state if we don't move on to the pressure leak test states.

9:46 am

Sean Nash

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

For now, we need to set authResponseReceived and authResponseValidTubingSet and authResponseModalityAccepted to TRUE until UI is properly responding to authentication request (TODO).

9:44 am

Sean Nash

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

For now, we need to set barcodeScanResponseReceived to TRUE here until barcode scan command is implemented.

9:29 am

Sean Nash

Add blank line before return statement.

Add blank line before return statement.

9:29 am

Sean Nash

Keep this blank line above group header.

Keep this blank line above group header.

9:28 am

Sean Nash

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Something is wrong here. We already had reg 33 at line 192 above. Reconcile with HDD.

Monday 01 Jun
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    /PIControllers.c
  2. … 1 more file in changeset.
5:35 pm

Vinayakam Mani

5:18 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

4:01 pm

Vinayakam Mani

Done.

Done.

4:01 pm

Vinayakam Mani

Done.

Done.

Friday 29 May
2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

10:58 am

Vinayakam Mani

Done.

Done.

10:07 am

Vendor - TEL - Jashwant Gantyada

10:06 am

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

9:43 am

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

9:41 am

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

9:41 am

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.