leahi-common

DDDefs.h

Clone Tools

Stats

Commits this week: 13
Total Committers: 17
Last Commit: 19 Aug
Commits this week: 13

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Sean Nash

Why are we commenting this out?

Why are we commenting this out?

1 hr ago

Sean Nash

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

2 hrs ago

Sean Nash

Why are we ending air trap control here?

Why are we ending air trap control here?

2 hrs ago

Sean Nash

Why is this commented out?

Why is this commented out?

2 hrs ago

Sean Nash

Add one more blank line before test support banner.

Add one more blank line before test support banner.

3 hrs ago

Sean Nash

Remove these blank lines.

Remove these blank lines.

Wednesday 19 Aug
1:07 pm

Michael Garthwaite

fix the id back to 255 in the struct

fix the id back to 255 in the struct

12:28 pm

Vinayakam Mani

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

11:14 am

Vinayakam Mani

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

11:11 am

Vinayakam Mani

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

11:07 am

Vinayakam Mani

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

10:59 am

Vinayakam Mani

close D80, D64, D14?

close D80, D64, D14?

10:56 am

Vinayakam Mani

D80 : open, D65: Close?

D80 : open, D65: Close?

Tuesday 18 Aug
4:46 pm

Vendor - TEL - Suresh Dharnala

4:41 pm

Vinayakam Mani , Sean Nash and Michael Garthwaite

3:48 pm

Sean Nash

This isn't right. Look at staging for correct code.

This isn't right. Look at staging for correct code.

11:39 am

Sean Nash

I'm seeing a lot of magic numbers. We should have #defines for these values.

I'm seeing a lot of magic numbers. We should have #defines for these values.

11:37 am

Sean Nash

Add doxygen comments to right.

Add doxygen comments to right.

Monday 17 Aug
5:03 pm

Sean Nash

4:56 pm

Sean Nash

10:16 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
Friday 14 Aug
12:31 pm

Sean Nash

Not needed? Add another BOOL for disinfection option received.

Not needed? Add another BOOL for disinfection option received.

12:23 pm

Sean Nash

Initialize this.

Initialize this.

12:15 pm

Sean Nash

Remove TODO

Remove TODO

12:14 pm

Sean Nash

Remove disable of ejector motor.

Remove disable of ejector motor.

12:09 pm

Sean Nash

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

12:07 pm

Sean Nash

Just move msg handlers from Messaging to here so you don't need a signal.

Just move msg handlers from Messaging to here so you don't need a signal.

12:06 pm

Sean Nash

Move to .c file to make private.

Move to .c file to make private.

12:05 pm

Sean Nash

Not needed.

Not needed.

11:18 am

Sean Nash

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.

Do we need summary review msgs? 0xA9 and 0xAA cover request for summary data.