DDDefs.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Why are we commenting this out?

Why are we commenting this out?

Magic number. Make a #define. Should this command be sent here or in transition function of pre-tx mode?

Magic number. Make a #define.
Should this command be sent here or in transition function of pre-tx mode?

Why are we ending air trap control here?

Why are we ending air trap control here?

Why is this commented out?

Why is this commented out?

Add one more blank line before test support banner.

Add one more blank line before test support banner.

Remove these blank lines.

Remove these blank lines.

fix the id back to 255 in the struct

fix the id back to 255 in the struct

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)

close D80, D64, D14?

close D80, D64, D14?

D80 : open, D65: Close?

D80 : open, D65: Close?

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 2 more files in changeset.
This isn't right. Look at staging for correct code.

This isn't right. Look at staging for correct code.

Merge branch 'staging' into LDT-4049-standby---fw-implementation---2

  1. … 1 more file in changeset.
I'm seeing a lot of magic numbers. We should have #defines for these values.

I'm seeing a lot of magic numbers. We should have #defines for these values.

Add doxygen comments to right.

Add doxygen comments to right.

LDT-4049:updated msg ids

LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
LEAHI-DD-FIRMWARE-LDT-4024_Disinfection (DD heat, heat+descale) - FW Implementation - 3/4:
Not needed? Add another BOOL for disinfection option received.

Not needed? Add another BOOL for disinfection option received.

Initialize this.

Initialize this.

Remove TODO

Remove TODO

Remove disable of ejector motor.

Remove disable of ejector motor.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Remove RotaryValve.h. It's obsolete and we should be using higher level controller Valves.h anyway.

Just move msg handlers from Messaging to here so you don't need a signal.

Just move msg handlers from Messaging to here so you don't need a signal.