leahi-common

MsgDefs.h

Clone Tools

Stats

Commits this week: 7
Total Committers: 19
Last Commit: 05 Jun
Commits this week: 7

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 min ago

Dara Navaei

If a retry goes wrong will you trigger an alarm?

If a retry goes wrong will you trigger an alarm?

1 min ago

Vendor - TEL - Arpita Srivastava

Add cummulativeRinsebackVolume_mL, fluidType, targetRinsebackVolumePlusAdditional_mL to outputs

Add cummulativeRinsebackVolume_mL, fluidType, targetRinsebackVolumePlusAdditional_mL to outputs

4 mins ago

Vendor - TEL - Arpita Srivastava

break this line

break this line

5 mins ago

Vendor - TEL - Arpita Srivastava

Add @Alarms

Add @Alarms

6 mins ago

Vendor - TEL - Arpita Srivastava

Add @Alarms

Add @Alarms

8 mins ago

Dara Navaei

Any fault alarm here?

Any fault alarm here?

8 mins ago

Vendor - TEL - Arpita Srivastava

fluidType is an input

fluidType is an input

8 mins ago

Vendor - TEL - Arpita Srivastava

break this line

break this line

9 mins ago

Vendor - TEL - Arpita Srivastava

Generally we put all the static functions after all the public functions. Can we reorganize the file as : Public functions Static functions Public Test functions

Generally we put all the static functions after all the public functions.
Can we reorganize the file as :
Public functions
Static functions
Public Test functions

12 mins ago

Vendor - TEL - Arpita Srivastava

Initialization is missing in the init function for variables from line 72 to 77.

Initialization is missing in the init function for variables from line 72 to 77.

13 mins ago

Vendor - TEL - Arpita Srivastava

Initialize in init.

Initialize in init.

14 mins ago

Vendor - TEL - Arpita Srivastava

Initialize in init. Check SyringPump.c for reference.

Initialize in init. Check SyringPump.c for reference.

21 mins ago

Dara Navaei

Have these variables been initialized correctly?

Have these variables been initialized correctly?

49 mins ago

Vendor - TEL - Arpita Srivastava

please add a TODO or remove commented code.

please add a TODO or remove commented code.

49 mins ago

Vendor - TEL - Arpita Srivastava

please add a TODO or remove commented code.

please add a TODO or remove commented code.

50 mins ago

Vendor - TEL - Arpita Srivastava

add resumeTreatmentAlarmResponseRequest to output

add resumeTreatmentAlarmResponseRequest to output

52 mins ago

Vendor - TEL - Arpita Srivastava

Update input - output list.

Update input - output list.

58 mins ago

Vendor - TEL - Arpita Srivastava

Add presUFRateMlMin to outputs

Add presUFRateMlMin to outputs

1 hr ago

Vendor - TEL - Arpita Srivastava

recirculateToBloodPrimeRequest is output.

recirculateToBloodPrimeRequest is output.

1 hr ago

Vendor - TEL - Arpita Srivastava

Add initialization for rinsebackToRecircRequest and recirculateToBloodPrimeRequest

Add initialization for rinsebackToRecircRequest and recirculateToBloodPrimeRequest

1 hr ago

Sean Nash

So then no need to initialize it here too. Remove " = FALSE".

So then no need to initialize it here too. Remove " = FALSE".

1 hr ago

Sean Nash

1 hr ago

Sean Nash

Wednesday 22 Jul
9:28 pm

Vendor - TEL - Suresh Dharnala

I agree but it is already in the init function.

I agree but it is already in the init function.

1:26 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

1:13 pm

Sean Nash

We generally don't add { } to switch cases unless they require local variable declarations.

We generally don't add { } to switch cases unless they require local variable declarations.

1:08 pm

Sean Nash

If we're not including a timestamp, can we just remove this line of code?

If we're not including a timestamp, can we just remove this line of code?

1:07 pm

Sean Nash

Why commented out?

Why commented out?

11:32 am

Sean Nash

Swap order of == for these 2 if statements - put constant on left side.

Swap order of == for these 2 if statements - put constant on left side.

11:19 am

Sean Nash

Why?

Why?