td-firmware / firmware / App / Modes

StateTxDialysis.c

Clone Tools

Stats

Commits this week: 2
Total Committers: 6
Last Commit: 05 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 05 Jun
10:29 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./StateTxDialysis.c
  2. … 21 more files in changeset.
10:08 am

Sean Nash

Thursday 04 Jun
9:52 am

Vendor - TEL - Jashwant Gantyada

9:00 am

Sean Nash

Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?

Wednesday 03 Jun
12:29 pm

Vinayakam Mani

12:28 pm

Vendor - TEL - Praneeth Bunne

LDT-4013: Refactored and updated logic.

Options
    • -1
    • +1
    ./StateTxDialysis.c
  2. … 6 more files in changeset.
Monday 01 Jun
10:28 am

Vendor - TEL - Jashwant Gantyada

where are we calling an alarm? i think we are only sending event change data in completeBolusToCumulative() right?

where are we calling an alarm?
i think we are only sending event change data in completeBolusToCumulative() right?

10:25 am

Vendor - TEL - Jashwant Gantyada

do we need this block?

do we need this block?

10:09 am

Vinayakam Mani

update the comment as required: ml or L?

update the comment as required: ml or L?

10:00 am

Sean Nash

10:00 am

Sean Nash

Friday 29 May
2:57 pm

Sean Nash and Vendor - TEL - Arpita Srivastava

2:43 pm

Vendor - TEL - Praneeth Bunne

LDT-4013: Address CR comments

Options
    • -9
    • +17
    ./StateTxDialysis.c
  2. … 2 more files in changeset.
2:33 pm

Vendor - TEL - Arpita Srivastava

Please add the min and max for tmp as well in the outputs.

Please add the min and max for tmp as well in the outputs.

2:25 pm

Sean Nash

rejReason = INVALID REQUEST FORMAT

rejReason = INVALID REQUEST FORMAT

Thursday 28 May
10:43 pm

Sean Nash

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

I think these remaining 4 else ifs need to have another && condition that your service is in idle state so that we don't change back into one of these 4 states while a bolus is in progress.

10:33 pm

Sean Nash

Can we restore the real code here yet? Ask Dara.

Can we restore the real code here yet? Ask Dara.

4:35 pm

Vendor - TEL - Praneeth Bunne

LDT-4013: Update code related to fluid bolus

Options
    • -11
    • +5
    ./StateTxDialysis.c
  2. … 5 more files in changeset.
Wednesday 27 May
8:00 pm

Vendor - TEL - Praneeth Bunne

LDT-4013: Merge latest staging into LDT-4013 and update code related to fluid bolus

Options
    • -16
    • +98
    ./StateTxDialysis.c
  2. … 22 more files in changeset.
1:22 pm

Sean Nash

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

Use the NEARLY_ZERO constant (instead 0f 0.01F) like the other one.

1:07 pm

Sean Nash

Add a doxygen comment above this array.

Add a doxygen comment above this array.

1:06 pm

Sean Nash

Add a doxygen comment above this array (similar to structures).

Add a doxygen comment above this array (similar to structures).

1:04 pm

Sean Nash

Add a doxygen comment above structure for the whole structure (see structure above for example).

Add a doxygen comment above structure for the whole structure (see structure above for example).

1:03 pm

Sean Nash

Add a doxygen comment for this definition.

Add a doxygen comment for this definition.

Tuesday 26 May
11:30 am

Raghu Kallala

remove camel case for SetPoint, instead use Setpoint Update line 659 too

remove camel case for SetPoint, instead use Setpoint
Update line 659 too

11:15 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

Can we rename this to TREATMENT_DURATION_CONFIRM_REQUEST_PAYLOAD_T

11:14 am

Vendor - TEL - Arpita Srivastava

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

Can we rename this to TREATMENT_DURATION_VALIDATE_REQUEST_PAYLOAD_T?

11:10 am

Vendor - TEL - Arpita Srivastava

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

What is the difference between the bicarbonateConcentrate and bicarbonate. Please update the comment.

11:09 am

Vendor - TEL - Arpita Srivastava

Looks like comment for 208 and 223 are swapped?

Looks like comment for 208 and 223 are swapped?

11:07 am

Vendor - TEL - Arpita Srivastava

please align the comments

please align the comments