leahi-fwcommon

Clone Tools

Stats

Commits this week: 25
Total Committers: 16
Last Commit: 16 Jun
Commits this week: 25

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Jul
9:33 am

Vendor - TEL - Arpita Srivastava

What is the use case of including this header?

What is the use case of including this header?

9:33 am

Vendor - TEL - Arpita Srivastava

What is the use case of including this header?

What is the use case of including this header?

9:32 am

Vendor - TEL - Arpita Srivastava

Should we move this up before the test functions?

Should we move this up before the test functions?

9:32 am

Vendor - TEL - Arpita Srivastava

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

Add @messages MSG_ID_TD_POST_FINAL_TEST_RESULT

9:32 am

Vendor - TEL - Arpita Srivastava

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

Add @messages MSG_ID_TD_POST_SINGLE_TEST_RESULT

9:31 am

Vendor - TEL - Arpita Srivastava

is the function description correct? change DG -> DD

is the function description correct?
change DG -> DD

9:31 am

Vendor - TEL - Arpita Srivastava

output is none

output is none

9:30 am

Vendor - TEL - Arpita Srivastava

add safetyShutdownSelfTestStatus to outputs

add safetyShutdownSelfTestStatus to outputs

9:28 am

Vendor - TEL - Arpita Srivastava

why is this line commented out? Should we remove it or add a TODO?

why is this line commented out? Should we remove it or add a TODO?

9:27 am

Vendor - TEL - Arpita Srivastava

Remove blank line

Remove blank line

9:26 am

Vendor - TEL - Arpita Srivastava

align comment

align comment

9:26 am

Vendor - TEL - Arpita Srivastava

break this line

break this line

9:25 am

Vendor - TEL - Arpita Srivastava

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

9:25 am

Vendor - TEL - Arpita Srivastava

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

add @messages MSG_ID_TD_UI_GENERIC_CONFIRMATION_REQUEST

9:24 am

Vendor - TEL - Arpita Srivastava

remove blank line

remove blank line

9:23 am

Vendor - TEL - Arpita Srivastava

Optional: should we rename these to dd and update the comment as well. dgPOSTPassed -> ddPOSTPassed dgPOSTResultReceived -> ddPOSTResultReceived dgVersion -> ddVersion

Optional: should we rename these to dd and update the comment as well.
dgPOSTPassed -> ddPOSTPassed
dgPOSTResultReceived -> ddPOSTResultReceived
dgVersion -> ddVersion

9:23 am

Vendor - TEL - Arpita Srivastava

add @alarms

add @alarms

9:23 am

Vendor - TEL - Arpita Srivastava

break line

break line

9:23 am

Vendor - TEL - Arpita Srivastava

add @alarms

add @alarms

9:22 am

Vendor - TEL - Arpita Srivastava

Should we use the test config TEST_CONFIG_DISABLE_ALARM_AUDIO?

Should we use the test config TEST_CONFIG_DISABLE_ALARM_AUDIO?

Thursday 30 Jul
5:52 pm

Sean Nash

5:07 pm

Vendor - TEL - Arpita Srivastava

align comments

align comments

5:02 pm

Vendor - TEL - Arpita Srivastava

All the else if should always have an ending else block. add a blank else block or change line 232 as else { if() { } }

All the else if should always have an ending else block.

add a blank else block or change line 232 as
else
{
if() { }
}

4:58 pm

Vendor - TEL - Arpita Srivastava

Add @alarms

Add @alarms

3:20 pm

Vendor - TEL - Jashwant Gantyada

will create a branch for dialin and make the necessary changes. Before merging will talk to Caitlynn to change the variable in automated testing as well.

will create a branch for dialin and make the necessary changes. Before merging will talk to Caitlynn to change the variable in automated testing as well.

1:38 pm

Vinayakam Mani

Remove empty line

Remove empty line

1:33 pm

Vinayakam Mani

Please sync this payload in DD firmware, Leahi-dialin and System Scripts.

Please sync this payload in DD firmware, Leahi-dialin and System Scripts.

1:28 pm

Vinayakam Mani

Align the indent

Align the indent

12:08 pm

Vinayakam Mani

Add the header description.

Add the header description.

12:04 pm

Vinayakam Mani

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?

Do we need to transition to next state DD_PREGEN_DRY_BICART_INITIAL_FILL here?