dd-firmware / firmware / App / Controllers

MixingControl.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 09:55
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

Thursday 02 Jul
3:26 pm

Vinayakam Mani

Add comments.

Add comments.

3:24 pm

Vinayakam Mani

Update Comments.

Update Comments.

3:23 pm

Vinayakam Mani

Siemens. Space after and before paranthesis.

Siemens. Space after and before paranthesis.

Wednesday 01 Jul
6:34 pm

Sean Nash

Can we be a little more specific about what conductivity we are returning in these functions? And I think we should include constants in the Inputs section of function headers.

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

2:32 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:
LEAHI-DD-FIRMWARE-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:
10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

moved.

moved.

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

9:36 am

Sean Nash

Move below Messaging.h to keep list in alphabetical order.

Move below Messaging.h to keep list in alphabetical order.

Tuesday 30 Jun
5:09 pm

Vinayakam Mani

Same here. Let's use only D29.

Same here. Let's use only D29.

5:02 pm

Vinayakam Mani

Suppose to use D74, Instead of D17 (for Control only).

Suppose to use D74, Instead of D17 (for Control only).

4:48 pm

Vinayakam Mani

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

4:44 pm

Vinayakam Mani

Missing Comment.

Missing Comment.

12:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4719_Dialysate Composition (Mixing) - FW Implementation - 4/1:
LEAHI-DD-FIRMWARE-LDT-4719_Dialysate Composition (Mixing) - FW Implementation - 4/1:
Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

Wednesday 24 Jun
2:53 pm

Vendor - TEL - Sameer Poyil

1:02 pm

Vendor - TEL - Sameer Poyil

12:50 pm

Vendor - TEL - Sameer Poyil

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

We need to keep D64 opened after supply to maintain the supply to bicarb green flow filter

Tuesday 23 Jun
3:38 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4409_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 3/1:
2:47 pm

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

2:40 pm

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

2:20 pm

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

2:04 pm

Vinayakam Mani

Init PI Controls missing here.

Init PI Controls missing here.

1:57 pm

Vinayakam Mani

13734.87F

13734.87F