dd-firmware / firmware / App / Monitors

Conductivity.c

Clone Tools

Stats

Commits this week: 6
Total Committers: 7
Last Commit: 16:39
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
3 hrs ago

Vendor - TEL - Jashwant Gantyada

LDT-4410 code review comments addressed

Options
    • -2
    • +2
    ./Conductivity.c
  2. … 5 more files in changeset.
6 hrs ago

Vinayakam Mani

Remove the TODO comment.

Remove the TODO comment.

6 hrs ago

Vinayakam Mani

align the comment.

align the comment.

6 hrs ago

Vinayakam Mani

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

6 hrs ago

Vinayakam Mani

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

6 hrs ago

Vinayakam Mani

decays to threshold level (4 PSI).

decays to threshold level (4 PSI).

6 hrs ago

Vinayakam Mani

remove all commented code.

remove all commented code.

6 hrs ago

Vinayakam Mani

Update comment. remove TODO if no more applicable.

Update comment. remove TODO if no more applicable.

6 hrs ago

Vinayakam Mani

FillWaterEndState?

FillWaterEndState?

6 hrs ago

Vinayakam Mani

Delete it.

Delete it.

6 hrs ago

Vinayakam Mani

Supply state (instead of drain). Updates Inputs and outputs across the file.

Supply state (instead of drain). Updates Inputs and outputs across the file.

6 hrs ago

Vinayakam Mani

When the BC fill completed and allow opening D65 for Chamber F fill?

When the BC fill completed and allow opening D65 for Chamber F fill?

6 hrs ago

Vinayakam Mani

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

6 hrs ago

Vinayakam Mani

50ms?

50ms?

7 hrs ago

Vinayakam Mani

Add comment to align with the rest of the implementation.

Add comment to align with the rest of the implementation.

8 hrs ago

Vinayakam Mani

Add outputs as well.

Add outputs as well.

8 hrs ago

Vinayakam Mani

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

Wednesday 15 Jul
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
Tuesday 14 Jul
2:58 pm

Michael Garthwaite

Saturday 11 Jul
5:38 am

Vendor - TEL - Sameer Poyil

right now pre and post are same. make a TODO to update post later

right now pre and post are same. make a TODO to update post later

5:36 am

Vendor - TEL - Sameer Poyil

its mixing control interval

its mixing control interval

Friday 10 Jul
4:49 pm

Vendor - TEL - Sameer Poyil

could you document th math behind the calculation also

could you document th math behind the calculation also

Thursday 09 Jul
2:13 pm

Sean Nash

Wednesday 08 Jul
1:48 pm

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

Wednesday 01 Jul
9:04 pm

Vendor - TEL - Sameer Poyil

please align this comments with below structure

please align this comments with below structure

9:03 pm

Vendor - TEL - Sameer Poyil

Please align the comments

Please align the comments

8:59 pm

Vendor - TEL - Sameer Poyil

could you please align it ?

could you please align it ?

6:08 pm

Sean Nash

Add blank line (should be 2 before test support banner).

Add blank line (should be 2 before test support banner).

6:07 pm

Sean Nash

Remove blank line.

Remove blank line.