dd-firmware / firmware / App

DDCommon.h

Clone Tools

Stats

Commits this week: 10
Total Committers: 9
Last Commit: 10 Jul
Commits this week: 10

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
7 hrs ago

Vinayakam Mani

Remove the TODO comment.

Remove the TODO comment.

7 hrs ago

Vinayakam Mani

align the comment.

align the comment.

7 hrs ago

Vinayakam Mani

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

Vendor - TEL - Sameer PoyilWhat's the value you are recommending for?

7 hrs ago

Vinayakam Mani

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pre...

Remove values in the comment, as they are changing during development (200ms persistence, 4 PSI low pressure, 17 PSI high pressure etc.,), instead use defined persistence, low or high threshold pressure etc.,

7 hrs ago

Vinayakam Mani

decays to threshold level (4 PSI).

decays to threshold level (4 PSI).

7 hrs ago

Vinayakam Mani

remove all commented code.

remove all commented code.

7 hrs ago

Vinayakam Mani

Update comment. remove TODO if no more applicable.

Update comment. remove TODO if no more applicable.

7 hrs ago

Vinayakam Mani

FillWaterEndState?

FillWaterEndState?

7 hrs ago

Vinayakam Mani

Delete it.

Delete it.

7 hrs ago

Vinayakam Mani

Supply state (instead of drain). Updates Inputs and outputs across the file.

Supply state (instead of drain). Updates Inputs and outputs across the file.

8 hrs ago

Vinayakam Mani

When the BC fill completed and allow opening D65 for Chamber F fill?

When the BC fill completed and allow opening D65 for Chamber F fill?

8 hrs ago

Vinayakam Mani

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

Can we rename this IsDryBicartChamberFillWindowOpen? ( removing BalChamber)

8 hrs ago

Vinayakam Mani

50ms?

50ms?

8 hrs ago

Vinayakam Mani

Add comment to align with the rest of the implementation.

Add comment to align with the rest of the implementation.

9 hrs ago

Vinayakam Mani

Add outputs as well.

Add outputs as well.

9 hrs ago

Vinayakam Mani

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

I guess we should have some minimum speed as well as like max speed. Please work with Abhijit on worst case min speed.

Saturday 11 Jul
5:38 am

Vendor - TEL - Sameer Poyil

right now pre and post are same. make a TODO to update post later

right now pre and post are same. make a TODO to update post later

5:36 am

Vendor - TEL - Sameer Poyil

its mixing control interval

its mixing control interval

Friday 10 Jul
4:49 pm

Vendor - TEL - Sameer Poyil

could you document th math behind the calculation also

could you document th math behind the calculation also

Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

3:07 pm

Dara Navaei

Bamboo Commit: Updated DDCommon.h with build versions from Bamboo.

Options
    • -1
    • +1
    ./DDCommon.h
Wednesday 24 Jun
1:02 pm

Vendor - TEL - Sameer Poyil

6:36 am

Raghu Kallala

Tuesday 23 Jun
2:47 pm

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

2:40 pm

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

2:20 pm

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.