dd-firmware / firmware / App / Modes

ModeGenDialysate.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 14
Last Commit: 01 Jul
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Vinayakam Mani

Delete it.

Delete it.

5 hrs ago

Vinayakam Mani

Remove blank spaces after =.

Remove blank spaces after =.

5 hrs ago

Vinayakam Mani

To be deleted this line?

To be deleted this line?

5 hrs ago

Vinayakam Mani

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as w...

Add a comment here to wait for BC switching to go Idle state and transition to spent chamber fill state. Also, add a space after (). Apply the same comment in the next Dialysate delivery state as well.

6 hrs ago

Vinayakam Mani

I guess we can remove the "balancingChamberFillInProgress" check here.

I guess we can remove the "balancingChamberFillInProgress" check here.

11 hrs ago

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
LEAHI-DD-FIRMWARE-LDT-4500_(DD) Alarm 75 and pressure build up during Chamber H fill
Wednesday 15 Jul
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DD-FIRMWARE-LDT-4611_HDF - FW Implementation - 5/4:
Thursday 02 Jul
10:29 am

Vendor - TEL - Jashwant Gantyada

9:06 am

Vinayakam Mani

Wednesday 01 Jul
6:34 pm

Sean Nash

Can we be a little more specific about what conductivity we are returning in these functions? And I think we should include constants in the Inputs section of function headers.

Can we be a little more specific about what conductivity we are returning in these functions?
And I think we should include constants in the Inputs section of function headers.

6:31 pm

Sean Nash

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:32 am

Vendor - TEL - Jashwant Gantyada

moved.

moved.

10:32 am

Vendor - TEL - Jashwant Gantyada

updated

updated

10:31 am

Vendor - TEL - Jashwant Gantyada

LDT-4719 code review comments

Options
    • -7
    • +6
    ./ModeGenDialysate.c
  2. … 2 more files in changeset.
10:18 am

Vendor - TEL - Jashwant Gantyada

updated

updated

9:36 am

Sean Nash

Move below Messaging.h to keep list in alphabetical order.

Move below Messaging.h to keep list in alphabetical order.

9:16 am

Sean Nash

balancingError is an input.

balancingError is an input.

Tuesday 30 Jun
5:09 pm

Vinayakam Mani

Same here. Let's use only D29.

Same here. Let's use only D29.

5:02 pm

Vinayakam Mani

Suppose to use D74, Instead of D17 (for Control only).

Suppose to use D74, Instead of D17 (for Control only).

4:48 pm

Vinayakam Mani

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

Move these functions to top area where all public functions defined. let's keep the static function after the public function.

4:44 pm

Vinayakam Mani

Missing Comment.

Missing Comment.

3:56 pm

Sean Nash

yes

yes

3:56 pm

Sean Nash

yes

yes

3:55 pm

Sean Nash

yes

yes

12:47 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4719_Dialysate Composition (Mixing) - FW Implementation - 4/1:
LEAHI-DD-FIRMWARE-LDT-4719_Dialysate Composition (Mixing) - FW Implementation - 4/1:
12:31 pm

Vendor - TEL - Jashwant Gantyada

LDT-4719 added initial alarms code for dialysate composition

Options
    • -0
    • +119
    ./ModeGenDialysate.c
  2. … 2 more files in changeset.
Wednesday 24 Jun
2:53 pm

Vendor - TEL - Sameer Poyil