AlarmDefs.h

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Where is testBatteryI2cStatusOverride (from BatteryDriver)?

Add blank line before return statement.

Add blank line before return statement.

Fixed

Fixed

Added

Added

Fixed

Fixed

Fixed

Fixed

Fixed

Fixed

Not required here since we are initializing in the main

Not required here since we are initializing in the main

Yes removed

Yes removed

Fixed

Fixed

Fixed

Fixed

fpgaActuatorSetPoints is an output. Input is none.

fpgaActuatorSetPoints is an output.
Input is none.

please remove extra line

please remove extra line

Output is none

Output is none

Please add message id.

Please add message id.

Output is none

Output is none

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Message id MSG_ID_OFF_BUTTON_PRESS_REQUEST looks wrong

Include "BPModule.h".

Include "BPModule.h".

BPModule is just one of the controllers - move this up into the controllers section.

BPModule is just one of the controllers - move this up into the controllers section.

We should not comment this out.

We should not comment this out.

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

It's still here. Do we need to initialize it here too or is it sufficient to initialize once from main at startup?

We are already executing this from TaskGeneral.c. Remove from here.

We are already executing this from TaskGeneral.c. Remove from here.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

Monitor is mis-spelled. Should be Control anyway. Move prior to execAlarmMgmt() above.

I think all flags are outputs (not just adult).

I think all flags are outputs (not just adult).

These look like outputs to me (not inputs).

These look like outputs to me (not inputs).

Can we restore this code?

Can we restore this code?

Remove FANS test.

Remove FANS test.

Remove.

Remove.

Move this to Messaging.c

Move this to Messaging.c