dd-firmware / firmware / App / Controllers

BalancingChamber.h

Clone Tools

Stats

Commits this week: 2
Total Committers: 6
Last Commit: 25 Jun
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
4:20 pm

Vendor - TEL - Sameer Poyil

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
4:11 pm

Vendor - TEL - Sameer Poyil

3:04 pm

Vinayakam Mani

Wednesday 24 Jun
2:47 pm

Vinayakam Mani

Space after if.

Space after if.

2:45 pm

Vinayakam Mani

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

Can we bring depressurize as well one of the states like fill, supply and drain? And the same way when one of the operations initiated and other should not kick in.

2:40 pm

Vinayakam Mani

remove empty space after d66pressure variable. or match the indent to previous statement.

remove empty space after d66pressure variable. or match the indent to previous statement.

2:36 pm

Vinayakam Mani

Add a TODO comment (remove later): this should be handled in IO/FP module.

Add a TODO comment (remove later): this should be handled in IO/FP module.

2:33 pm

Vinayakam Mani

Update comment.

Update comment.

2:32 pm

Vinayakam Mani

Add comment.

Add comment.

2:31 pm

Vinayakam Mani

Depressurize?

Depressurize?

2:22 pm

Vinayakam Mani

Fix the typo.

Fix the typo.

1:49 pm

Vendor - TEL - Sameer Poyil

moved to general task

moved to general task

6:36 am

Raghu Kallala

Monday 22 Jun
12:29 pm

Vinayakam Mani

Can we move this exec at task level, independent of Drybicart operations?

Can we move this exec at task level, independent of Drybicart operations?

12:27 pm

Vinayakam Mani

Comment missing?

Comment missing?

Thursday 18 Jun
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
LEAHI-DD-FIRMWARE-LDT-4612_Dialysate Composition (Dry Bicarbonate) - FW Iteration - 4/1:
Monday 08 Jun
9:21 am

Vendor - TEL - Jashwant Gantyada

comments start's with uppercase?

comments start's with uppercase?

9:15 am

Vendor - TEL - Jashwant Gantyada

comment starts with capital letter?

comment starts with capital letter?

9:14 am

Vendor - TEL - Jashwant Gantyada

do we have to leave a blank line after this?

do we have to leave a blank line after this?

Thursday 04 Jun
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
Friday 22 May
11:17 am

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./BalancingChamber.h
  2. … 18 more files in changeset.
11:11 am

Vendor - TEL - Jashwant Gantyada

10:50 am

Sean Nash and Vinayakam Mani

Thursday 21 May
3:24 pm

Vendor - TEL - Jashwant Gantyada

restored

restored

3:24 pm

Sean Nash

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

Not sure why Crucible is showing it this way. Let's just re-review these diffs.

3:18 pm

Sean Nash

Should be #ifndef

Should be #ifndef

3:13 pm

Sean Nash

Should be #ifndef I think.

Should be #ifndef I think.

3:06 pm

Sean Nash

Can we make these low priority and 999 rank?

Can we make these low priority and 999 rank?

1:32 pm

Vendor - TEL - Jashwant Gantyada

LDT-3963 addressed code review comments and restored the fault mode transition

Options
    • -2
    • +1
    ./BalancingChamber.h
  2. … 9 more files in changeset.
Sunday 17 May
11:34 pm

Sean Nash

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.

It is weird that we're responding so far from request. It is not clear to me that Dialin has requested anything at this point.