dd-firmware / firmware / App

DDCommon.h

Clone Tools

Stats

Commits this week: 3
Total Committers: 9
Last Commit: 14 Jul
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 11 Jul
5:38 am

Vendor - TEL - Sameer Poyil

right now pre and post are same. make a TODO to update post later

right now pre and post are same. make a TODO to update post later

5:36 am

Vendor - TEL - Sameer Poyil

its mixing control interval

its mixing control interval

Friday 10 Jul
4:49 pm

Vendor - TEL - Sameer Poyil

could you document th math behind the calculation also

could you document th math behind the calculation also

Monday 06 Jul
12:59 pm

Sean Nash

What is 4 (or 2)? Should be #define or enum or const.

What is 4 (or 2)? Should be #define or enum or const.

Friday 26 Jun
1:41 pm

Vinayakam Mani

Same as above.

Same as above.

1:39 pm

Vinayakam Mani

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

Add an event here, when time out happens. Event data should capture fresh side and spent side fill completion status.

1:37 pm

Vinayakam Mani

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

You may need to comment/ remove this condition. the pressure stabilized flag should set only when pressure is met (not on chamber fill request)

Thursday 25 Jun
4:14 pm

Vendor - TEL - Sameer Poyil

it shouldn't be the default value

it shouldn't be the default value

Wednesday 24 Jun
1:02 pm

Vendor - TEL - Sameer Poyil

6:36 am

Raghu Kallala

Tuesday 23 Jun
2:47 pm

Vinayakam Mani

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband co...

There are multiple target bicarb conductivity calls, getBicarbTargetConductivity, getBicardConductivityPre and getBicarConductivityPost. If you are using getBicarbTargetConductivity for deadband control check, use the same for 'runPIcontroller' function as well.

2:40 pm

Vinayakam Mani

This should return POST conductivity.

This should return POST conductivity.

2:20 pm

Vinayakam Mani

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

getBicarbConductivityPre() -> This function gets the target conductivity from the mixing algorithm. For testing, recommend using defined value and check the behavior.

2:04 pm

Vinayakam Mani

Init PI Controls missing here.

Init PI Controls missing here.

1:57 pm

Vinayakam Mani

13734.87F

13734.87F

Monday 22 Jun
12:18 pm

Vinayakam Mani

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5...

Leave a comment here that for acid control period, 3 cycles of balancing chamber switching time (for ex, Qd :600, 3sec is switching period, 3 * 3 = 9 Sec control interval) and for bicarb control, 5 cycles of balancing chamber switching time.

12:14 pm

Vinayakam Mani

both acid and bicarb mix volume

both acid and bicarb mix volume

12:07 pm

Vinayakam Mani

Add MULTIPLIER at the end.

Add MULTIPLIER at the end.

11:47 am

Vinayakam Mani

Initialize at init function.

Initialize at init function.

11:47 am

Vinayakam Mani

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

Remove sample filter ms and task interval. rename as FILTER_SIZE_MULTIPLIER.

11:37 am

Vinayakam Mani

Lets remove this.

Lets remove this.

10:22 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DD-FIRMWARE-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
Monday 01 Jun
5:35 pm

Vinayakam Mani

5:18 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

4:01 pm

Vinayakam Mani

Done.

Done.

4:01 pm

Vinayakam Mani

Done.

Done.

Friday 29 May
2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

10:58 am

Vinayakam Mani

Done.

Done.

10:07 am

Vendor - TEL - Jashwant Gantyada