leahi-dialin / leahi_dialin / common

msg_ids.py

Clone Tools

Stats

Commits this week: 14
Total Committers: 16
Last Commit: 25 Jun
Commits this week: 14

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

4:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
LEAHI-DIALIN-LDT-4072_Power Loss - FW Implementation - 2/3:
4:13 pm

Vendor - TEL - Sameer Poyil

4:13 pm

Zoltan Miskolci

3:20 pm

Nicholas Ramirez

change to td_powerOff_wARNING

change to td_powerOff_wARNING

11:05 am

Zoltan Miskolci

Could you just leave it as or TBD_B7 = 0xB7 ? So it will be easy to see that the msg id location is free to use

Could you just leave it as or TBD_B7 = 0xB7 ?
So it will be easy to see that the msg id location is free to use

Wednesday 24 Jun
9:23 pm

Vinayakam Mani

2:56 pm

Vinayakam Mani

Update the name.

Update the name.

Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

9:49 am

Dara Navaei

LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
LEAHI-DIALIN-LDT-4787_NON-FEATURE: SW Misc & Enhc - SW - 01 - Power Control - Shutdown - R&I
9:36 am

Nicholas Ramirez

9:36 am

Nicholas Ramirez

9:35 am

Nicholas Ramirez

Monday 22 Jun
3:50 pm

Zoltan Miskolci

fix msg_id

Options
    • -2
    • +2
    ./msg_ids.py
3:34 pm

Zoltan Miskolci

fix msg_ids

Options
    • -0
    • +19
    ./msg_ids.py
2:55 pm

Zoltan Miskolci

1:00 pm

Vinayakam Mani and Michael Garthwaite

Thursday 18 Jun
4:53 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4692-tx-adjust-vitals-alarm-limits' into staging

Options
    • -0
    • +2
    ./msg_ids.py
  2. … 1 more file in changeset.
4:39 pm

Behrouz NematiPour

Merge branch 'feature/LDT-4672-power-control' into staging

Options
    • -2
    • +3
    ./msg_ids.py
4:34 pm

Zoltan Miskolci

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

4:33 pm

Tiffany Mejia and Behrouz NematiPour

4:32 pm

Tiffany Mejia and Behrouz NematiPour

4:23 pm

Behrouz NematiPour

resolved.

resolved.

3:48 pm

Tiffany Mejia and Behrouz NematiPour

2:36 pm

Zoltan Miskolci

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

2:35 pm

Zoltan Miskolci

Fix Spacing please to be consistent with the rest of the variables

Fix Spacing please to be consistent with the rest of the variables