leahi-dialin / leahi_dialin / dd / modules

substitution_pump.py

Clone Tools

Stats

Commits this week: 0
Total Committers: 2
Last Commit: 25 Jun
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

Thursday 11 Jun
1:30 pm

Sean Nash

Wednesday 10 Jun
1:21 pm

Michael Garthwaite

9:44 am

Zoltan Miskolci

Tuesday 09 Jun
11:40 am

Vinayakam Mani

10:53 am

Michael Garthwaite

fixed. thanks!

fixed. thanks!

Monday 08 Jun
11:20 am

Dara Navaei

LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin
LEAHI-DIALIN-LDT-4484_[Dialin] Create Dry Self Test module in dialin
Thursday 04 Jun
11:09 am

Michael Garthwaite

LDT-4001: added pump id to sensor list in message handler

Options
    • -4
    • +4
    ./substitution_pump.py
10:37 am

Michael Garthwaite

LDT-4001: fixed naming of data structures

Options
    • -4
    • +6
    ./substitution_pump.py
  2. … 1 more file in changeset.
9:40 am

Michael Garthwaite

LDT-4001: updates to sub pump based on refactoring that was merged into staging.

Options
    • -18
    • +35
    ./substitution_pump.py
  2. … 3 more files in changeset.
Tuesday 02 Jun
9:30 am

Zoltan Miskolci

I would like to ask to check out the substitution pump on the develop branch and update it based on that. There are some changes thanks to the merging of the refactor.

I would like to ask to check out the substitution pump on the develop branch and update it based on that.
There are some changes thanks to the merging of the refactor.

Monday 01 Jun
11:29 am

Vinayakam Mani

looks there are some more payloads in publish function. please add the other parameters here.

looks there are some more payloads in publish function. please add the other parameters here.

Friday 29 May
11:49 am

Michael Garthwaite

LDT-4000: updated message IDs. Updated test config for beta 1.9 and 2.0. implemented substitution pump module

Options
    • -0
    • +112
    ./substitution_pump.py
  2. … 2 more files in changeset.
11:02 am

Dara Navaei

LEAHI-DIALIN-LDT-4001_HDF - FW Implementation - 2/4:
LEAHI-DIALIN-LDT-4001_HDF - FW Implementation - 2/4: