leahi-dialin / leahi_dialin

utils

Clone Tools

Stats

Commits this week: 8
Total Committers: 5
Last Commit: 25 Jun
Commits this week: 8

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

Tuesday 16 Jun
9:53 am

Zoltan Miskolci

7:40 am

Vendor - TEL - Sameer Poyil

Monday 15 Jun
4:37 pm

Zoltan Miskolci

Merge branch 'LDT-4721-extra_param' into staging

Options
    • -4
    • +9
    ./abstract_classes.py
  2. … 1 more file in changeset.
3:59 pm

Zoltan Miskolci

3:32 pm

Dara Navaei

LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table
LEAHI-DIALIN-LDT-4160_[Request] Get function for full detailed Alarm Table
2:35 pm

Raghu Kallala and Michael Garthwaite

1:50 pm

Zoltan Miskolci

Fixed non working modules

Options
    • -2
    • +4
    ./abstract_classes.py
  2. … 2 more files in changeset.
11:02 am

Zoltan Miskolci

fixes

Options
    • -2
    • +5
    ./abstract_classes.py
  2. … 6 more files in changeset.
9:11 am

Zoltan Miskolci

Rename to CanChannels

Rename to CanChannels

9:11 am

Zoltan Miskolci

Rename to CanChannels

Rename to CanChannels

7:52 am

Vendor - TEL - Sameer Poyil

Let it be there. Because of this, i could not complete the 30+ data broadcast.

Let it be there. Because of this, i could not complete the 30+ data broadcast.

Friday 12 Jun
1:36 pm

Vinayakam Mani

align the indent or remove blank space before =

align the indent or remove blank space before =

1:33 pm

Vinayakam Mani

remove blank space before =

remove blank space before =

9:16 am

Dara Navaei

LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request
LEAHI-DIALIN-LDT-4721_Add extra parameter to start pregen request
Thursday 11 Jun
1:31 pm

Sean Nash

1:30 pm

Sean Nash

1:30 pm

Sean Nash

9:13 am

Zoltan Miskolci

Put this into a dataclass folder under common, so we start structuring it.

Put this into a dataclass folder under common, so we start structuring it.

9:12 am

Zoltan Miskolci

Not in use, don't need to add

Not in use, don't need to add

9:12 am

Zoltan Miskolci

2 empty lines please

2 empty lines please

9:11 am

Zoltan Miskolci

2 lines between functions please

2 lines between functions please

9:11 am

Zoltan Miskolci

remove empty line

remove empty line

9:11 am

Zoltan Miskolci

remove 3rd empty line

remove 3rd empty line

9:10 am

Zoltan Miskolci

Rename to CanChannels

Rename to CanChannels