ConductivitySensors.c

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
WIP on LDT-4734-temp-comp-conductivity

LDT-4734: uncompensated integration wip

  1. … 3 more files in changeset.
LDT-4734: implemented temperature compensation for conductivity on a per sensor basis.

LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:
LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:
LDT-4734: init commit for temp compensation conductivity

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 5 more files in changeset.
Remove blank line.

Remove blank line.

LDT-4485: code review comments

  1. … 1 more file in changeset.
LDT-4485: fixed conductivity monitoring overriding changes from staging. fixed cal and version request for conductivity sensors.

  1. … 3 more files in changeset.
LDT-4485: updates conductivity cal check test config to check FPGA data to determine if the system is communicating to a dead sensor.

remove blank line

remove blank line

remove blank line

remove blank line

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

update the message ID.

update the message ID.

Update the comment for all publish counter start counts.

Update the comment for all publish counter start counts.

LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
LDT-4485: implemented resistance data message for conductivity sensors.

  1. … 3 more files in changeset.
On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop si...

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch...

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

Remove extra blank line.

Remove extra blank line.

Where is call to HDF controller?

Where is call to HDF controller?

Monitors should come before mode mgmt above.

Monitors should come before mode mgmt above.

What about HemoDiaFiltration.h?

What about HemoDiaFiltration.h?

What about initHDF?

What about initHDF?

Where is HemoDiaFiltration.h?

Where is HemoDiaFiltration.h?

Why does this file name have pound signs pre/post?

Why does this file name have pound signs pre/post?

This macro is already defined in Common.h.

This macro is already defined in Common.h.