dd-firmware / firmware / App / Drivers

ConductivitySensors.c

Clone Tools

Stats

Commits this week: 3
Total Committers: 8
Last Commit: 25 Jun
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Thursday 25 Jun
2:21 pm

Michael Garthwaite

WIP on LDT-4734-temp-comp-conductivity

LDT-4734: uncompensated integration wip

Options
    • -1
    • +36
    ./ConductivitySensors.c
  2. … 3 more files in changeset.
9:35 am

Michael Garthwaite

LDT-4734: implemented temperature compensation for conductivity on a per sensor basis.

Options
    • -26
    • +57
    ./ConductivitySensors.c
9:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:
LEAHI-DD-FIRMWARE-LDT-4734_Water Treatment and Degassing - FW Iteration - 5/4:
8:54 am

Michael Garthwaite

LDT-4734: init commit for temp compensation conductivity

Options
    • -0
    • +54
    ./ConductivitySensors.c
Wednesday 24 Jun
6:36 am

Raghu Kallala

Tuesday 16 Jun
12:49 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -2
    • +2
    ./ConductivitySensors.c
  2. … 5 more files in changeset.
12:41 pm

Michael Garthwaite

10:59 am

Vinayakam Mani and Vendor - TEL - Jashwant Gantyada

10:58 am

Vendor - TEL - Jashwant Gantyada

10:44 am

Vinayakam Mani

Remove blank line.

Remove blank line.

10:37 am

Michael Garthwaite

LDT-4485: code review comments

Options
    • -2
    • +0
    ./ConductivitySensors.c
  2. … 1 more file in changeset.
Monday 15 Jun
12:36 pm

Michael Garthwaite

LDT-4485: fixed conductivity monitoring overriding changes from staging. fixed cal and version request for conductivity sensors.

Options
    • -12
    • +52
    ./ConductivitySensors.c
  2. … 3 more files in changeset.
11:39 am

Michael Garthwaite

LDT-4485: updates conductivity cal check test config to check FPGA data to determine if the system is communicating to a dead sensor.

Options
    • -106
    • +117
    ./ConductivitySensors.c
Tuesday 09 Jun
12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:03 pm

Vinayakam Mani

remove blank line

remove blank line

12:02 pm

Vinayakam Mani

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

11:57 am

Vinayakam Mani

update the message ID.

update the message ID.

11:53 am

Vinayakam Mani

Update the comment for all publish counter start counts.

Update the comment for all publish counter start counts.

Thursday 04 Jun
10:33 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
10:21 am

Michael Garthwaite

LDT-4485: implemented resistance data message for conductivity sensors.

Options
    • -0
    • +54
    ./ConductivitySensors.c
  2. … 3 more files in changeset.
Wednesday 27 May
2:46 pm

Sean Nash

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop si...

On DD f/w side, this should just be a simple pump controller. States should be Off and On (control to commanded Qsub). There is no flow sensor for feedback control, so assuming this is open loop similar to UF pump.
GenDialysate mode will have an HDF sub-state that signals this controller from Off to On and would also call separate controller for heater and separate (Switches) monitor for door sensors.

With all of that in mind, I think this unit should have a simpler name like SubPump.

2:39 pm

Sean Nash

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch...

I think there should be some state monitoring for potential alarm(s) in here too. Similar to BP door on TD f/w side where the current mode/state can signal this unit that it expects specific switch state(s) (e.g. while in HDF state, we would expect the cap to be open and stowed and we would want to alarm if that was not the case).

2:36 pm

Sean Nash

Remove extra blank line.

Remove extra blank line.

2:31 pm

Sean Nash

Where is call to HDF controller?

Where is call to HDF controller?

2:31 pm

Sean Nash

Monitors should come before mode mgmt above.

Monitors should come before mode mgmt above.

2:30 pm

Sean Nash

What about HemoDiaFiltration.h?

What about HemoDiaFiltration.h?

2:29 pm

Sean Nash

What about initHDF?

What about initHDF?

2:28 pm

Sean Nash

Where is HemoDiaFiltration.h?

Where is HemoDiaFiltration.h?

2:24 pm

Sean Nash

Why does this file name have pound signs pre/post?

Why does this file name have pound signs pre/post?

2:14 pm

Sean Nash

This macro is already defined in Common.h.

This macro is already defined in Common.h.