AlarmMgmtTD.h

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
it will be adjusted when I merge latest staging

it will be adjusted when I merge latest staging

not required anymore, forgot to remove

not required anymore, forgot to remove

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

I think a comment here is needed. Keep it and maybe mention rinseback alarm responses too.

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

Maybe this should be handled in OperationModes exec since it applies to all confirmations (not just alarm related ones).

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

There will be confirmations that are not handled here (e.g. power off). So we shouldn't fault in default - we should do nothing.

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

Shutdown would be handled somewhere else (buttons.c probably). It's not related to alarms.

Is this still possible since we're not returning to TxPaused from rinseback anymore?

Is this still possible since we're not returning to TxPaused from rinseback anymore?

Is rinseback completed an indication that we've done a blood prime following a temporary break? If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjus...

Is rinseback completed an indication that we've done a blood prime following a temporary break?
If so, I guess this makes sense, but we have to do more than increase the UF volume. We have to adjust the UF rate so that we will reach the new (larger) UF volume when the treatment completes.
We also need to add RB volume to UF volume in pre-tx when treatment parameters are given/validated (for the final rinseback which we will always have so we should just plan for it before treatment starts).

What if multiple confirmations pending? Which ID will this function return?

What if multiple confirmations pending? Which ID will this function return?

Align comments. Should substitution pump data be moved down to 0xBA instead of commented out?

Align comments.
Should substitution pump data be moved down to 0xBA instead of commented out?

LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
LEAHI-TD-FIRMWARE-LDT-4040_Rinseback - FW Implementation - 3/10:
change accordingly

change accordingly

Rename to AlarmTableResposnePayload

Rename to AlarmTableResposnePayload

test instead of handle

test instead of handle

Please typecast alarmID to resolve warning. ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

Please typecast alarmID to resolve warning.

ALARM_T alarm = getAlarmProperties( ( ALARM_ID_T )alarmID );

mesage payload is not an input. We correctly mentioned it in the param. Input should be none as we are not reading any global or static variable declared at file level.

mesage payload is not an input. We correctly mentioned it in the param.
Input should be none as we are not reading any global or static variable declared at file level.

Output should be none as we are not updating any global or static variable declared at file level.

Output should be none as we are not updating any global or static variable declared at file level.

Please convert the function to have only single point of return. You can assign result = FALSE here. Also check for whitespace characters. Use 4 spaces instead of tab.

Please convert the function to have only single point of return.
You can assign result = FALSE here.

Also check for whitespace characters. Use 4 spaces instead of tab.

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

Add space : Change all sizeof(ALARM_ID_T) to sizeof( ALARM_ID_T )

Why are we adding this header here?

Why are we adding this header here?

LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
LEAHI-TD-FIRMWARE-LDT-4160_[Request] Get function for full detailed Alarm Table
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 21 more files in changeset.
Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?