Activity dd-firmware/firmware/App/Controllers/ROPump.c

Since these are coming from UI s/w now (right?), I don't think they should begin with "test" which we reserve for messages that only come from Dialin. Move up above "test" functions.

Since these are coming from UI s/w now (right?), I don't think they should begin with "test" which we reserve for messages that only come from Dialin.
Move up above "test" functions.

53 mins ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

This is a common unit - could be built into DD or TD f/w. Need #ifdef to see if _DD_ or _TD_ build so you know which messaging and records to initialize.

56 mins ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

These don't look like UI alarms. Comment suggests we already know what to call these. Why aren't we just using the names we want?

57 mins ago

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Make sure Dialin gets these too when you merge.

6:36 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-3975-2
started review

LEAHI-DD-FIRMWARE-LDT-3975_Water Treatment and Degassing - FW Iteration - 4/4:

8:48 am

Dara Navaei

More
LEAHI-DD-FIRMWARE-LDT-4246-1
started review

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo

2:17 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Add a blank line before group end marker.

1:40 pm

Sean Nash

More
Re: LEAHI-DD-FIRMWARE-LDT-3735-1
commented on review

Are we only doing DD messages? And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal ...

Are we only doing DD messages?
And since these could be coming from UI now, these shouldn't be considered "Dialin" messages anymore and should be moved up to section before 0x8000 IDs where normal system messages are defined.

8:24 am

Dara Navaei

More
fd21f03
changed 6 files
LDT-3223-dialysate-flow-rate---dd---mode-6-5-2026, LDT-3272-software-update---dd-firmware and 43 more LEAHI-DD-FIRMWARE-LDT-3735-1 LEAHI-DD-FIRMWARE-LDT-4246-1 LEAHI-DD-FIRMWARE-LDT-2004-9

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

- -1
- +1
./ROPump.c
- History
- Source
- Diff
./ROPump.c
… 5 more files in changeset.

8:15 am

Michael Garthwaite

5:31 pm

Sean Nash and Vinayakam Mani

More
LEAHI-DD-FIRMWARE-LDT-3218-4
finished reviewing

4:12 pm

Michael Garthwaite

by the end of S27 we will know if we need to keep this module. If so, then we can integrate it into PIControllers.c

3:37 pm

Vinayakam Mani

More
Re: LEAHI-DD-FIRMWARE-LDT-3218-4
commented on review

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. e...

If this is the core change, can we introduce this logic in PI controller.c itself with a simple flag check (say, if 'IsDerivativeEnabled" set to true, add the derivative signal to Control signal. else, just a PI control signal would work. (something similar to Feed forward enabled flag)

9:52 am