leahi-dialin / leahi_dialin

dd

Clone Tools

Stats

Commits this week: 3
Total Committers: 14
Last Commit: 13 Jul
Commits this week: 3

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
5 hrs ago

Zoltan Miskolci

Sunday 19 Jul
8:27 am

Vendor - TEL - Sameer Poyil

Wednesday 15 Jul
3:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DIALIN-LDT-4611_HDF - FW Implementation - 5/4:
Monday 13 Jul
3:28 pm

Michael Garthwaite

Changed handler debug to contain raw message and timestamp of recv

Options
    • -1
    • +1
    ./modules/alarms.py
    • -1
    • +1
    ./modules/balancing_chamber.py
    • -1
    • +1
    ./modules/blood_leak.py
    • -1
    • +1
    ./modules/concentrate_pump.py
    • -1
    • +1
    ./modules/conductivity_sensors.py
    • -1
    • +1
    ./modules/dialysate_pump.py
    • -1
    • +1
    ./modules/drybicart.py
    • -1
    • +1
    ./modules/events.py
    • -1
    • +1
    ./modules/gen_dialysate.py
    • -1
    • +1
    ./modules/heaters.py
    • -1
    • +1
    ./modules/levels.py
    • -1
    • +1
    ./modules/mixing_cntrl.py
    • -1
    • +1
    ./modules/post_gen_dialysate.py
    • -1
    • +1
    ./modules/pre_gen_dialysate.py
    • -1
    • +1
    ./modules/pressure_sensors.py
  16. … 34 more files in changeset.
2:46 pm

Tiffany Mejia and Michael Garthwaite

10:33 am

Michael Garthwaite

Merge branch 'staging' into LDT-4874

Options
    • -59
    • +31
    ./modules/conductivity_sensors.py
  2. … 1 more file in changeset.
10:32 am

Michael Garthwaite

LDT-4874: updates to td handlers for timing

Options
    • -1
    • +2
    ./modules/alarms.py
    • -2
    • +5
    ./modules/conductivity_sensors.py
  3. … 17 more files in changeset.
10:09 am

Michael Garthwaite

LDT-4874: updates to timing for handlers

Options
    • -1
    • +4
    ./modules/alarms.py
    • -3
    • +4
    ./modules/balancing_chamber.py
    • -1
    • +4
    ./modules/blood_leak.py
    • -0
    • +4
    ./modules/conductivity_sensors.py
    • -0
    • +4
    ./modules/drybicart.py
    • -0
    • +5
    ./modules/events.py
    • -0
    • +4
    ./modules/gen_dialysate.py
    • -0
    • +4
    ./modules/levels.py
    • -0
    • +4
    ./modules/post_gen_dialysate.py
    • -0
    • +4
    ./modules/pre_gen_dialysate.py
    • -1
    • +4
    ./modules/pressure_sensors.py
    • -0
    • +4
    ./modules/rinse_pump.py
    • -0
    • +4
    ./modules/spent_chamber_fill.py
    • -1
    • +4
    ./modules/substitution_pump.py
    • -0
    • +4
    ./modules/ultrafiltration.py
  16. … 11 more files in changeset.
Sunday 12 Jul
11:44 pm

Behrouz NematiPour

Zoltan and I had a meeting, and the counter solution he provided works better than mine. He explained to me that my proposed solution has flaws. RESOLVED.

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

Friday 10 Jul
3:28 pm

Sean Nash

Thursday 09 Jul
12:06 pm

Zoltan Miskolci

time measurement

Options
    • -0
    • +6
    ./modules/concentrate_pump.py
    • -0
    • +4
    ./modules/dialysate_pump.py
    • -0
    • +4
    ./modules/heaters.py
    • -0
    • +4
    ./modules/mixing_cntrl.py
    • -0
    • +5
    ./modules/temperature_sensors.py
    • -1
    • +5
    ./modules/voltages.py
11:23 am

Michael Garthwaite

10:48 am

Dara Navaei

LEAHI-DIALIN-LDT-4874_Invalid values interrupt script
LEAHI-DIALIN-LDT-4874_Invalid values interrupt script
9:58 am

Michael Garthwaite

Wednesday 08 Jul
1:46 pm

Vinayakam Mani , Sean Nash and Zoltan Miskolci

10:45 am

Sean Nash

Thursday 02 Jul
9:54 am

Zoltan Miskolci

Wednesday 01 Jul
8:58 pm

Vendor - TEL - Sameer Poyil , Vinayakam Mani and Zoltan Miskolci

8:58 pm

Vendor - TEL - Sameer Poyil

3:17 pm

Dara Navaei

LEAHI-DIALIN-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:
LEAHI-DIALIN-LDT-4614_Dialysate Composition (Dry Bicarbonate) - FW Implementation - 5/1:
3:02 pm

Zoltan Miskolci

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility. 1. The conversion module's bytearray to value methods work, but th...

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

  • with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
  • with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.


Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

  • with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
  • with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed
3:00 pm

Michael Garthwaite

fixed. thanks!

fixed. thanks!

3:00 pm

Michael Garthwaite

fixed. thanks

fixed. thanks

2:58 pm

Michael Garthwaite

LDT-4734: code review comments

Options
    • -0
    • +5
    ./modules/conductivity_sensors.py
  2. … 1 more file in changeset.
2:40 pm

Zoltan Miskolci

Add uncompensated conductivity to the init too

Add uncompensated conductivity to the init too

2:40 pm

Zoltan Miskolci

Add uncompensated conductivity to the init too

Add uncompensated conductivity to the init too

1:11 pm

Michael Garthwaite

LDT-4734: updates to conductivity message

Options
    • -0
    • +5
    ./modules/conductivity_sensors.py
  2. … 2 more files in changeset.
12:33 pm

Behrouz NematiPour

RESOLVED for now.

RESOLVED for now.

12:32 pm

Behrouz NematiPour

I would not do that because the function names and messages for each project should be different to avoid confusion. I think that is fine for now. RESOLVED.

I would not do that because the function names and messages for each project should be different to avoid confusion.
I think that is fine for now.

RESOLVED.

12:11 pm

Behrouz NematiPour

So the same channels are used for both the Leahi and Denali? I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW. My point is that the CAN Channel...

So the same channels are used for both the Leahi and Denali?
I am not talking about how collisions are handled; that is handled by the CAN driver, not the FW or SW.
My point is that the CAN Channels by themselves do not have the meaning we want; they are only a priority.
As we defined them, we gave them a meaning as a category; therefore, it is better to name them the Denali/Leahi Channels rather than the CAN Channels.