Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
- Added new enums - Renamed some members - Added missing _str_lists - Adjusted code for renaming

  1. … 11 more files in changeset.
We will need to get the event_id first, to know how to process the content as Operation status content is different from rest. So this line is just for getting the event id, and based on the resul...

We will need to get the event_id first, to know how to process the content as Operation status content is different from rest.

So this line is just for getting the event id, and based on the result, process the rest into the correct variables

removed

removed

remove if we are sure about the message ID

remove if we are sure about the message ID

Will we need this after adding the below code?

Will we need this after adding the below code?

LEAHI-DIALIN-LDT-5482_[Dry Self Test] Update the module to match the current dev changes
LEAHI-DIALIN-LDT-5482_[Dry Self Test] Update the module to match the current dev changes
I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

I think that's what is usually shown, the first 7 char, but in this case it might have been a typo

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

Was it a regulatory requirement before to have 7 characters from commit ID or something we implemented?

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update. For more ...

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

- Updated descriptions - Refactored FP module - Refactored DD module

  1. … 43 more files in changeset.
Refactor changes #1

  1. … 63 more files in changeset.
LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor
LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor
LEAHI-DIALIN-LDT-4874_Invalid values interrupt script
LEAHI-DIALIN-LDT-4874_Invalid values interrupt script
references to Denali has been removed

references to Denali has been removed

Removed Denali reference

  1. … 75 more files in changeset.
Shouldn't we use Leahi instead of Denali?

Shouldn't we use Leahi instead of Denali?

- Updated DD and TD module - Updaterd TDValvePosition enum

  1. … 54 more files in changeset.
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
- DD refactor Changes in FP and TD module

  1. … 32 more files in changeset.
LDT-3984 addressed review comments

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines? I think the second lvl_sen is not needed, the one without the offset.

What's the point of this line if you overwrite the lvl_sen value in the next 2 lines?
I think the second lvl_sen is not needed, the one without the offset.