leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Change PRES_OCCL to PRESSURE

Change PRES_OCCL to PRESSURE

Maybe move OperationModes.c?

Maybe move OperationModes.c?

Use generic confirmation functions/messages.

Use generic confirmation functions/messages.

Move this function to OperationModes.c.

Move this function to OperationModes.c.

From here forward, we can just call sendMessage() with appropriate params.

From here forward, we can just call sendMessage() with appropriate params.

Use generic helper function (sendMessage) in MessageSupport.c.

Use generic helper function (sendMessage) in MessageSupport.c.

Use generic confirmation functions/messages for off button.

Use generic confirmation functions/messages for off button.

Remove change.

Remove change.

You only addressed the first part of my comment above.

You only addressed the first part of my comment above.

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

This medium alarm is ID 196 (from enum above). So I would expect it to be at the bottom of this table. Why are you placing it here?

Put TRUE on left side of ==

Put TRUE on left side of ==

"u" comes before "y".

"u" comes before "y".

BROADCAST_INTERVAL?

BROADCAST_INTERVAL?

removed

removed

pre-gen does not need substitution rate as its only treatment related.

pre-gen does not need substitution rate as its only treatment related.

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

its used in handleDialysateDeliveryRequestMsg() to set the sub pump's speed. please review the changes thoroughly.

removed

removed

is it a dummy parameter? where are you using it ?

is it a dummy parameter? where are you using it ?

Why pre-gen missing substitutionrate ? not required ?

Why pre-gen missing substitutionrate ? not required ?

please removed commented code

please removed commented code

please remove commented code

please remove commented code

remove blank line

remove blank line

remove blank line

remove blank line

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

Please see if you can define a function to handle this and call that function here, to reduce the number of code lines in this function.

added

added

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!

fixed. thanks!