leahi-common

Clone Tools

Stats

Commits this week: 17
Total Committers: 19
Last Commit: 14 Aug 25
Commits this week: 17

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 08 Jun
3:32 pm

Sean Nash

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

60 should be coming from somewhere. Is there not a treatment parameter for vitals measurement interval? I think we do (TREATMENT_PARAM_BP_MEAS_INTERVAL).

3:27 pm

Sean Nash

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

Make a local BOOL variable and assign it TRUE or FALSE with a ternary operator and then return that local BOOl variable.

3:08 pm

Sean Nash

These should be moved down to an "else" in the if statement below (payload length check).

These should be moved down to an "else" in the if statement below (payload length check).

3:04 pm

Sean Nash

It doesn't look like these memsets are necessary. Consider removing them.

It doesn't look like these memsets are necessary. Consider removing them.

3:03 pm

Sean Nash

Remove blank line.

Remove blank line.

3:02 pm

Sean Nash

Can you move this down with the other vitals functions?

Can you move this down with the other vitals functions?

11:20 am

Dara Navaei

LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
LEAHI-TD-FIRMWARE-LDT-4329_Edit Treatment Parameters During Treatment - FW Implementation - 5/4:
9:21 am

Vendor - TEL - Jashwant Gantyada

comments start's with uppercase?

comments start's with uppercase?

9:15 am

Vendor - TEL - Jashwant Gantyada

comment starts with capital letter?

comment starts with capital letter?

9:14 am

Vendor - TEL - Jashwant Gantyada

do we have to leave a blank line after this?

do we have to leave a blank line after this?

Friday 05 Jun
4:14 pm

Sean Nash

Just use 0x0 and 0xFFFFFFFF

Just use 0x0 and 0xFFFFFFFF

4:13 pm

Sean Nash

NUM_OF_BATTERY_REGISTERS - 1

NUM_OF_BATTERY_REGISTERS - 1

4:13 pm

Sean Nash

Put 2 items at end of the list here: BATTERY_END_OF_LIST_TIME_TO_PUBLISH NUM_OF_BATTERY_REGISTERS

Put 2 items at end of the list here:
BATTERY_END_OF_LIST_TIME_TO_PUBLISH
NUM_OF_BATTERY_REGISTERS

4:10 pm

Sean Nash

Put this one back to NUM_OF_BATTERY_DEVICES.

Put this one back to NUM_OF_BATTERY_DEVICES.

4:08 pm

Sean Nash

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

Don't need min/max for this. Just use 0x0 and 0xFFFFFFFF where needed.

4:04 pm

Sean Nash

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

I don't think we need these min/max #defines. Just use 0x0 for minimums and 0xFFFFFFFF for maximums.

1:36 pm

Sean Nash

1:23 pm

Vendor - TEL - Arpita Srivastava

Please add Alarm ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

Please add Alarm
ALARM_ID_TD_PRIME_COMPLETED_HIGH and ALARM_ID_TD_SOFTWARE_FAULT

1:19 pm

Vendor - TEL - Arpita Srivastava

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

Add alarm ALARM_ID_TD_PRIME_COMPLETED_MEDIUM

1:16 pm

Vendor - TEL - Arpita Srivastava

Please add currentPreTreatmentState to inputs.

Please add currentPreTreatmentState to inputs.

1:07 pm

Vendor - TEL - Arpita Srivastava

currentPreTxRecircState looks like an input.

currentPreTxRecircState looks like an input.

10:08 am

Sean Nash

Thursday 04 Jun
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
1:44 pm

Sean Nash

Put recirc state after Rx state (both here in switch statement and also in enumeration).

Put recirc state after Rx state (both here in switch statement and also in enumeration).

1:43 pm

Sean Nash

Put in alphabetical order (before Timers.h).

Put in alphabetical order (before Timers.h).

1:41 pm

Sean Nash

Where do we trigger high priority prime completed alarm?

Where do we trigger high priority prime completed alarm?

1:39 pm

Sean Nash

Dialysate rate should be set to the Qd user setting (from Tx params).

Dialysate rate should be set to the Qd user setting (from Tx params).

1:32 pm

Sean Nash

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

Add /// doxygen comment for this enumeration and ///< doxygen comments to right of each enum in the list.

10:33 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
LEAHI-DD-FIRMWARE-LDT-4485_(DD) Conductivity sensors (D17 and D27 ) not working consisitently
9:52 am

Vendor - TEL - Jashwant Gantyada