leahi-fwcommon

Clone Tools
  • last updated a few minutes ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

Doesn't look fixed. 717 and 732 are swapped (and so out of order). This array should be in order by rank.

Fixed

Fixed

Fixed

Fixed

Fixed

Fixed

Yes, Fixed

Yes, Fixed

Agree Fixed

Agree Fixed

No fixed

No fixed

Fixed

Fixed

Fixed

Fixed

This was merge issue earlier at that time I commented out and I forget to uncomment Fixed

This was merge issue earlier at that time I commented out and I forget to uncomment
Fixed

Fixed

Fixed

Fixed

Fixed

Prime is not in staging, thats why I added to confirm RX, I will fix that to prime state

Prime is not in staging, thats why I added to confirm RX, I will fix that to prime state

Don't we need to go to prime state after dry self-tests are done?

Don't we need to go to prime state after dry self-tests are done?

TaskGeneral is included twice. Remove this one.

TaskGeneral is included twice. Remove this one.

Remove {} in case if not necessary (i.e. no local variables).

Remove {} in case if not necessary (i.e. no local variables).

Remove blank line.

Remove blank line.

Keep a blank line between library includes and normal includes.

Keep a blank line between library includes and normal includes.

Why?

Why?

Why?

Why?

Please align the ranking in order

Please align the ranking in order

Why commented out?

Why commented out?

Align comments.

Align comments.

Remove extra blank line.

Remove extra blank line.

This should be 2 lines like the one below.

This should be 2 lines like the one below.

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Can we add current DD recirculation Dwell Time, WCID recirculation Dwell time variables as well and get the required dialin/automated system testing changes?

Add D92 pump On at 50ml/min.

Add D92 pump On at 50ml/min.

Remove D95 from closed state and add D88 to closed state.

Remove D95 from closed state and add D88 to closed state.

D35, D40, D34,D91,D95 : Open M12, P39 : Closed ( keep a TODO comment to remove them later)

D35, D40, D34,D91,D95 : Open
M12, P39 : Closed ( keep a TODO comment to remove them later)