leahi-common

Clone Tools

Stats

Commits this week: 34
Total Committers: 20
Last Commit: 16 Oct 24
Commits this week: 34

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Saturday 22 Aug
3:50 pm

Vendor - TEL - Varshini Nagabooshanam

Yes,

Yes,

3:49 pm

Vendor - TEL - Varshini Nagabooshanam

In pre-treatment

In pre-treatment

3:49 pm

Vendor - TEL - Varshini Nagabooshanam

Fixed

Fixed

3:49 pm

Vendor - TEL - Varshini Nagabooshanam

Yes, fixed

Yes, fixed

1:37 pm

Sean Nash

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

Add a command to turn air pump off here in this state (since we aren't doing that in transition anymore to prevent large pressure drop).

1:36 pm

Sean Nash

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

Don't turn off air pump here - looks like we lose too much air pressure when we do that. Move this command to the stabilize state handler (I'll add a comment there).

12:15 pm

Sean Nash

You removed it here, but where did it go? I expected to see it in next case below.

You removed it here, but where did it go? I expected to see it in next case below.

12:04 pm

Sean Nash

Align "="

Align "="

12:04 pm

Sean Nash

Add comment to right.

Add comment to right.

10:46 am

Sean Nash

Better to say != TRUE here.

Better to say != TRUE here.

10:45 am

Sean Nash

Add TODO comment as to whether we should trigger an alarm/fault here.

Add TODO comment as to whether we should trigger an alarm/fault here.

10:42 am

Sean Nash

Add blank line after declaration. Fix indent.

Add blank line after declaration.
Fix indent.

10:41 am

Sean Nash

We can un-comment syringe pump stop now.

We can un-comment syringe pump stop now.

10:10 am

Sean Nash

I think this function should be private (called by public message handler).

I think this function should be private (called by public message handler).

10:09 am

Sean Nash

Should this be static (private)?

Should this be static (private)?

9:41 am

Sean Nash

Ok to reject for now (because we don't want TD to go to disinfection state while DD doesn't). Add TODO to handle other disinfection options when they are implemented.

Ok to reject for now (because we don't want TD to go to disinfection state while DD doesn't). Add TODO to handle other disinfection options when they are implemented.

9:39 am

Sean Nash

Add a blank line between banner and comment.

Add a blank line between banner and comment.

9:38 am

Sean Nash

gen to post gen and post gen to standby are simple commands unlike the pre-gen and gen dialysate requests which have a bunch of parameters. I think we should keep the simple transition requests in ...

gen to post gen and post gen to standby are simple commands unlike the pre-gen and gen dialysate requests which have a bunch of parameters. I think we should keep the simple transition requests in this enum with the disinfection requests and eventually any other simple command requests.

9:36 am

Sean Nash

DD only needs a command to start a specific disinfection. This can be achieved with the one generic command message here.

DD only needs a command to start a specific disinfection. This can be achieved with the one generic command message here.

9:33 am

Sean Nash

I was thinking we would have a generic command message with a single enum for the command ID. This one message could handle many different commands including post get to standby command.

I was thinking we would have a generic command message with a single enum for the command ID. This one message could handle many different commands including post get to standby command.

Friday 21 Aug
10:57 am

Vinayakam Mani

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for ...

Please add another sub condition for now that sub mode is in DD_POST_GEN_DIALYSATE_STATE_COMPLETE. Make sure you transition substate from Post gen start state to complete state for now to wait for this request.

10:57 am

Michael Garthwaite

for now, keep this only related for disinfection cmds. for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

for now, keep this only related for disinfection cmds.

for Post gen and standby. Follow the similiar messaging like pre-gen and gen dialysate requests and the reply back. ( but one message/handler )

10:50 am

Vinayakam Mani

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

are we rejecting this request for Aug Month demo, I guess, you still need to accept these requests and set the corresponding pending DD disinfect request flags.

10:47 am

Michael Garthwaite

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

Do we have a MSG_ID for the selection of disinfection? If not, lets rename and repurpose this one.

10:44 am

Vinayakam Mani

MSG_ID_TD_DD_POSTGEN_STANDBY_REQUEST: to perform post gen and standby mode request transition.

MSG_ID_TD_DD_POSTGEN_STANDBY_REQUEST: to perform post gen and standby mode request transition.

10:36 am

Michael Garthwaite

10:26 am

Vendor - TEL - Varshini Nagabooshanam

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-stat...

Those transitions to send the pressure result event. That was carried over from the previous implementation. Since the state changes are already reported through the common sub-state/operation-status events, I'll remove the pressure result event from those individual transitions for consistency.

9:53 am

Michael Garthwaite

Need the TDDef.h changes that include the enum naming updates

Need the TDDef.h changes that include the enum naming updates

9:47 am

Michael Garthwaite

9:42 am

Sean Nash

Should reset happen when transitioning out of this state (into next state)? I think we want to allow time for pressure to stabilize while open to atmosphere after we open these valves before we res...

Should reset happen when transitioning out of this state (into next state)? I think we want to allow time for pressure to stabilize while open to atmosphere after we open these valves before we reset the offsets.