leahi-common

Clone Tools

Stats

Commits this week: 19
Total Committers: 17
Last Commit: 16 Oct 24
Commits this week: 19

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Sunday 26 Apr
3:41 pm

Sean Nash

It looks like you deleted it instead of fixing it.

It looks like you deleted it instead of fixing it.

3:40 pm

Sean Nash

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

Need to request syringe pump to start a seek before we go to seek state. It's not implemented yet, so just put a TODO comment for now.

3:39 pm

Sean Nash

Need to check heparin bolus volume > 0 too.

Need to check heparin bolus volume > 0 too.

3:38 pm

Sean Nash

Don't we need to check this too still?

Don't we need to check this too still?

3:37 pm

Sean Nash

Do we need to reset authStartTime here before we go to next state?

Do we need to reset authStartTime here before we go to next state?

3:35 pm

Sean Nash

Put positive case first ( TRUE == ...), then alarm and reject cases.

Put positive case first ( TRUE == ...), then alarm and reject cases.

3:33 pm

Sean Nash

No occlusion sensor in Leahi. Delete variable and references to it.

No occlusion sensor in Leahi. Delete variable and references to it.

3:32 pm

Sean Nash

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

We should now send the scanned text to the UI s/w for authentication before we go to next state where we wait for UI response.

3:31 pm

Sean Nash

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

Remove extra l at end of flag name (mis-spelled). And why are we sending this flag with scan event? Seems like the Received flag is what you want here.

3:26 pm

Sean Nash

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

The barcode reader is under TD f/w control via the FPGA (not implemented yet). So asking UI s/w to do a scan doesn't make sense.

3:25 pm

Sean Nash

What is this flag for? And why is it only set here and not above where test passed. Also, we are going to the loaded check state, but we are not requesting a scan first.

What is this flag for? And why is it only set here and not above where test passed.
Also, we are going to the loaded check state, but we are not requesting a scan first.

3:21 pm

Sean Nash

Local declarations should come first - move up above reset function above.

Local declarations should come first - move up above reset function above.

3:16 pm

Sean Nash

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

Leahi doesn't have occlusion sensor, so don't need this if statement. Not sure we need this start state. Maybe we can start in the wait for door close state.

3:07 pm

Sean Nash

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

start state function has same description as wait for door close state function. We shouldn't need 2 states to ensure door is closed.

3:03 pm

Sean Nash

I meant that you should move this function up, not init function down.

I meant that you should move this function up, not init function down.

3:02 pm

Sean Nash

Change to initDrySelfTests() and move to top (should be first function).

Change to initDrySelfTests() and move to top (should be first function).

3:00 pm

Sean Nash

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

prime state not yet implemented. comment this out w/ TODO comment and add an assignemtn to Rx state here for now.

2:57 pm

Sean Nash

Why is this commented out?

Why is this commented out?

2:44 pm

Sean Nash

2:43 pm

Sean Nash

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

So this unit manages the sending of record messages, right? I don't see a unit managing read/write/erase jobs. Where is that queue?

2:41 pm

Sean Nash

I think this enum should be in a different header file. I don't think this unit uses this enum.

I think this enum should be in a different header file. I don't think this unit uses this enum.

2:39 pm

Sean Nash

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

Slot size and offsets can probably be private and maybe better placed in a different header file? I don't see why a msg Q would need/use/be responsible for this kind of thing.

2:32 pm

Sean Nash

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

These addresses should be calculated in init function from sector start addresses (call driver get function to get these) and your offsets and stored in static variables within the .c file.

2:29 pm

Sean Nash

Do these need to be public? I think only the driver should have to know sector addresses and sizes. If other units want to know these things, they should call a function in this driver to get them.

Do these need to be public?
I think only the driver should have to know sector addresses and sizes.
If other units want to know these things, they should call a function in this driver to get them.

2:25 pm

Sean Nash

I think isSectorStartAddress is a better function name.

I think isSectorStartAddress is a better function name.

2:24 pm

Sean Nash

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thoug...

Be careful with bufferSize. Make sure you understand what it means (e.g. is it bytes or words). I believe the FAPI functions deal in 4-byte words and it caused some issues for Dara because he thought this was bytes.

2:21 pm

Sean Nash

don't forget to add function headers.

don't forget to add function headers.

2:21 pm

Sean Nash

// **************** private functions **************

// **************** private functions **************

2:18 pm

Sean Nash

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

I think this driver should be moved to FWCommon folder as it should work the same for both DD and TD firmware.

2:17 pm

Sean Nash

Add a blank line before group end marker.

Add a blank line before group end marker.