leahi-common

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
You need to initialize the valve states and timer etc., as similar to when you jump from idle state to fill water state. Fill water state just checks the pressure check condition.

You need to initialize the valve states and timer etc., as similar to when you jump from idle state to fill water state. Fill water state just checks the pressure check condition.

Add TODO comment that it should be removed later.

Add TODO comment that it should be removed later.

Add comment.

Add comment.

Set default publish interval to 1 sec.

Set default publish interval to 1 sec.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Does default mean invalid state (s/w fault) or does it mean it's a state that we don't need to do anything for? If latter, add a comment here saying that.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Use if else or ternary operator to set BOOL to TRUE or FALSE explicitly.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Add a TODO comment to adjust this when new syringe pump assembly is ready.

Is this still necessary? Comment out before merging to staging.

Is this still necessary? Comment out before merging to staging.

Why are registers being repeated? Sync w/ latest HDD.

Why are registers being repeated? Sync w/ latest HDD.

Can we remove this commented out line of code?

Can we remove this commented out line of code?

Why is this commented out?

Why is this commented out?

Why is state transition and publish removed?

Why is state transition and publish removed?

Remove empty line.

Remove empty line.

Remove empty line.

Remove empty line.

Remove empty line.

Remove empty line.

I guess, instead of bicarbChamberPreGenFillRequested, you need to check bicarbChamberFillRequested.

I guess, instead of bicarbChamberPreGenFillRequested, you need to check bicarbChamberFillRequested.

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks

fixed thanks