StateServices

Clone Tools
  • last updated a few seconds ago
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

Arpita, we don't want to use doxygen style comments for function prototypes since we cover functions with the function headers. so this is the proper type of comments.

Bubble status, Low and high level level sensors.

Bubble status, Low and high level level sensors.

Input : Blood pump door status?

Input : Blood pump door status?

To be restored?

To be restored?

Are these being initialized in the init function?

Are these being initialized in the init function?

Need to resolve the merge issues?

Need to resolve the merge issues?

pauseBolusResumeState is input

pauseBolusResumeState is input

add alarm

add alarm

Replace // to ///< for line 56 to 60

Replace // to ///< for line 56 to 60

Use // comments for function prototypes.

Use // comments for function prototypes.

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

Either no comment or // comment for function prototypes since doxygen captures function details from function headers.

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

These were fine (and preferred) as // because doxygen gets function details from function headers in the .c file.

Should we be looking at tubing set type instead of modality here?

Should we be looking at tubing set type instead of modality here?

Can we not determine this now? Why TODO?

Can we not determine this now? Why TODO?

Shouldn't we be checking tubing set type instead of modality here?

Shouldn't we be checking tubing set type instead of modality here?

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

verify given type is valid (< NUM_OF_TUBE_SET_TYPES) and trigger s/w fault if invalid.

Initialize to UNKNOWN type. Remove TODO.

Initialize to UNKNOWN type. Remove TODO.

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

Consider adding TUBE_SET_TYPE_UNKNOWN = 0 as first enum so you can initialize a type variable to something before we install/identify the type.

Use /// when above, use ///< when to the right. Also remove extra space before Tube

Use /// when above, use ///< when to the right.
Also remove extra space before Tube

Change // to ///<

Change // to ///<

LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
LEAHI-TD-FIRMWARE-LDT-4013_Fluid Bolus - FW Implementation - 2/4:
Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

  1. … 18 more files in changeset.
LDT-4013: Merge latest staging into LDT-4013, resolved merge conflicts and addressed CR comments

    • -0
    • +437
    ./TubeSetAutoEject.c
    • -0
    • +335
    ./TubeSetInstall.c
  1. … 9 more files in changeset.
Should this check be moved to the fluid bolus exec function?

Should this check be moved to the fluid bolus exec function?