dd-firmware / firmware / App / Controllers

Ultrafiltration.c

Clone Tools

Stats

Commits this week: 1
Total Committers: 5
Last Commit: 31 Dec 69
Commits this week: 1

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 12 Jun
9:14 am

Sean Nash

Is this normal UF volume or normal UF volume + Iso UF Volume?

Is this normal UF volume or normal UF volume + Iso UF Volume?

9:11 am

Sean Nash

Consider moving this validity check into the setTDRequestedGenDState function. And what should we do if it's not valid?

Consider moving this validity check into the setTDRequestedGenDState function.
And what should we do if it's not valid?

9:07 am

Sean Nash

Why only these states are valid?

Why only these states are valid?

9:05 am

Sean Nash

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Remove list of states from comment. It is not a complete list and we shouldn't even try to list them here anyway.

Monday 08 Jun
9:21 am

Vendor - TEL - Jashwant Gantyada

comments start's with uppercase?

comments start's with uppercase?

9:15 am

Vendor - TEL - Jashwant Gantyada

comment starts with capital letter?

comment starts with capital letter?

9:14 am

Vendor - TEL - Jashwant Gantyada

do we have to leave a blank line after this?

do we have to leave a blank line after this?

Thursday 04 Jun
3:03 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
Tuesday 02 Jun
9:50 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
LEAHI-DD-FIRMWARE-LDT-4011_Isolated UF (DD) - FW Implementation - 1/2:
Monday 01 Jun
5:35 pm

Dara Navaei

Bamboo Commit: Updated the Copyright section and replaced tabs with 4 spaces

Options
    • -1
    • +1
    ./Ultrafiltration.c
  2. … 9 more files in changeset.
5:35 pm

Vinayakam Mani

5:18 pm

Sean Nash and Vendor - TEL - Jashwant Gantyada

4:01 pm

Vinayakam Mani

Done.

Done.

4:01 pm

Vinayakam Mani

Done.

Done.

Friday 29 May
2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

2:48 pm

Sean Nash

Use ternary to explicitly assign TRUE or FALSE.

Use ternary to explicitly assign TRUE or FALSE.

10:58 am

Vinayakam Mani

Done.

Done.

10:07 am

Vendor - TEL - Jashwant Gantyada

10:06 am

Vendor - TEL - Jashwant Gantyada

I think we also need this to be uncommented, as we were running into an alarm because of this.

I think we also need this to be uncommented, as we were running into an alarm because of this.

9:43 am

Vinayakam Mani

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

Added new field for d1 filtered temperature and restored the pressure sensor temperature.

9:41 am

Vinayakam Mani

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

The latest code from staging has an update and fixes this comment. It's not showing here, since the file was already reviewed.

9:41 am

Vinayakam Mani

as discussed, these were outcome of the test results. we will review these gains with latest controller.

as discussed, these were outcome of the test results. we will review these gains with latest controller.

9:40 am

Vinayakam Mani

Done.

Done.

9:40 am

Vinayakam Mani

Done.

Done.

Sunday 17 May
10:59 pm

Sean Nash

Should we set this flag to FALSE at top of loop?

Should we set this flag to FALSE at top of loop?

10:58 pm

Sean Nash

Should we just set this flag to FALSE at top of loop?

Should we just set this flag to FALSE at top of loop?

10:50 pm

Sean Nash

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

These P being so much bigger than I are going to be very volatile (lots of big ups and downs). I think these should all be primarily I with much smaller P coefficients.

10:47 pm

Sean Nash

Update comment.

Update comment.

10:46 pm

Sean Nash

Is this eventually going to be d1Temp?

Is this eventually going to be d1Temp?

Wednesday 06 May
1:52 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2:
LEAHI-DD-FIRMWARE-LDT-3958_Dialysate Temperature - FW Implementation - 2/2: