leahi-dialin / leahi_dialin

dd

Clone Tools

Stats

Commits this week: 27
Total Committers: 14
Last Commit: 25 Jun
Commits this week: 27

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Today
1 hr ago

Zoltan Miskolci

Being generic is the whole point of it. It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading. It was renamed to CanMessage for 2 reas...

Being generic is the whole point of it.
It was renamed because this is a dialin dedicated to Leahi unit and calling the messages DenaliMessage is misleading.
It was renamed to CanMessage for 2 reason:
1. This is a Leahi only dialin, so there is no need to differentiate between different type of Can Messages as there would be only 1 type
2. Calling it CanMessage will make it more future compatible when the dialin get copied over for a new unit development (unlikely in the foreseeable future but possible), removing the need to rename it again

1 hr ago

Zoltan Miskolci

There is no Leahi or Denali CANChannels. There are CAN channels and the naming is what that channel is being used for. The collision occurs in the FW and the FW handles it before sending out a mess...

There is no Leahi or Denali CANChannels.
There are CAN channels and the naming is what that channel is being used for.
The collision occurs in the FW and the FW handles it before sending out a message.
When reading a CAN, there are no collisions, so there are no priorities. So I have no clue what you want here.

1 hr ago

Zoltan Miskolci

done

done

1 hr ago

Zoltan Miskolci

I have no idea what you are referring to as the link is not working. The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, tha...

I have no idea what you are referring to as the link is not working.
The need to define the type and the name of the data being read is necessary, so if it's not here it will be somewhere else, that we can't escape.
Exporting that to different files won't serve a purpose and will only increase complexity as when debugging you will need to reference a separate file.
For the defs it made sense as they are used multiple places, but what a message contains is a single use place, so storing it separately is meaningless as it won't have any use outside of this single function.

Friday 26 Jun
3:17 pm

Dara Navaei

LEAHI-DIALIN-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
LEAHI-DIALIN-LDT-4410_Dialysate Composition (Mixing) - FW Implementation - 3/1:
Thursday 25 Jun
5:33 pm

Behrouz NematiPour

I am happy to see that this old code is improving. I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically. Examples can be found in t...

I am happy to see that this old code is improving.
I would recommend using the Conversion module instead of strings and DataTypes, as it handles everything automatically.
Examples can be found in the following file in this CR:
https://devapps.diality.us/cru/#LEAHI-DIALIN-LDT-4484-1CFR-84688

5:19 pm

Behrouz NematiPour

Please add a docstring for the function. including the intention and parameters with their intentions.

Please add a docstring for the function.
including the intention and parameters with their intentions.

5:17 pm

Behrouz NematiPour

Same for CanChannels. The Channels we are referring to here are Leahi's or Denali's. Channels mainly have no meaning beyond their priorities when a collision occurs.

Same for CanChannels.
The Channels we are referring to here are Leahi's or Denali's.
Channels mainly have no meaning beyond their priorities when a collision occurs.

5:15 pm

Behrouz NematiPour

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending. I'm not sure why the name was...

I recommend DenaliMessage or LeahiMessage, as CanMessage is generic, whereas Leahi/Denali indicate that the protocol is also implemented in the message we are sending.
I'm not sure why the name was changed, as it is a lot of change.
Also, there is no CAN Message.
There is a CAN Frame and a Leahi/Denali Message.

4:13 pm

Vendor - TEL - Sameer Poyil

4:13 pm

Zoltan Miskolci

4:07 pm

Zoltan Miskolci

1:30 pm

Michael Garthwaite

Merge branch 'LDT-4733-request-add-variables' into develop

Options
    • -2
    • +2
    ./modules/voltages.py
1:29 pm

Michael Garthwaite

LDt-4733: fixed typo in voltage module

Options
    • -2
    • +2
    ./modules/voltages.py
10:45 am

Michael Garthwaite

Merge branch 'LDT-4733-request-add-variables' into develop

Options
    • -9
    • +17
    ./modules/voltages.py
  2. … 1 more file in changeset.
10:41 am

Michael Garthwaite

LDT-4733: voltage monitoring updates.

Options
    • -9
    • +17
    ./modules/voltages.py
  2. … 1 more file in changeset.
8:47 am

Dara Navaei

LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
LEAHI-DIALIN-LDT-4733_(Request) Add variables to capture AC/DC heater electrical data
Wednesday 24 Jun
9:23 pm

Vinayakam Mani

9:14 pm

Vendor - TEL - Sameer Poyil

LDT-4612 addressed review commend

Options
    • -2
    • +2
    ./modules/mixing_cntrl.py
2:56 pm

Vinayakam Mani

Update the name.

Update the name.

2:39 pm

Vendor - TEL - Sameer Poyil

2:33 pm

Vendor - TEL - Sameer Poyil

LDT-4612 dialin updates for mixing conrol and dry bicart

Options
    • -0
    • +23
    ./modules/drybicart.py
    • -65
    • +67
    ./modules/mixing_cntrl.py
  3. … 1 more file in changeset.
Tuesday 23 Jun
10:40 am

Zoltan Miskolci

updated

updated

10:32 am

Raghu Kallala

Remove extra spaces before comment

Remove extra spaces before comment

Monday 22 Jun
2:55 pm

Zoltan Miskolci

2:31 pm

Zoltan Miskolci

Merge branch 'LDT-4732-fpga_version_fix' into develop

Options
    • -30
    • +2
    ./dialysate_delivery.py
  2. … 3 more files in changeset.
1:00 pm

Vinayakam Mani and Michael Garthwaite

Thursday 18 Jun
4:34 pm

Zoltan Miskolci

Please consult the FW-SW integration xls file for MSG_ID reservations. Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritt...

Please consult the FW-SW integration xls file for MSG_ID reservations.
Please add the ones you need to that list as without missing any reservations for IDs the randomly added IDs will be overwritten by reserved ones.

2:36 pm

Zoltan Miskolci

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

If it's mixing control, then rename the parameters to reflect it, these names suggest a different module

2:35 pm

Zoltan Miskolci

Fix Spacing please to be consistent with the rest of the variables

Fix Spacing please to be consistent with the rest of the variables