leahi-dialin / leahi_dialin / dd / modules

conductivity_sensors.py

Clone Tools

Stats

Commits this week: 2
Total Committers: 3
Last Commit: 31 Dec 69
Commits this week: 2

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few minutes ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Monday 04 May
5:46 pm

Dara Navaei

LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
LEAHI-DIALIN-LDT-3904_[OpMode] The operation mode broadcasts does not return the 3rd and 4th level modes
Thursday 05 Mar
10:46 am

Zoltan Miskolci

10:25 am

Raghu Kallala

Tuesday 03 Mar
4:58 pm

Michael Garthwaite

3:28 pm

Zoltan Miskolci

removed

removed

9:13 am

Michael Garthwaite

Remove this extra line

Remove this extra line

Friday 20 Feb
10:46 am

Dara Navaei

LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
LEAHI-DIALIN-LDT-3557_[Documantation][Enhancement] Add documentation header to dialin variables
Thursday 12 Feb
1:29 pm

Zoltan Miskolci

10:41 am

Michael Garthwaite and Raghu Kallala

9:48 am

Zoltan Miskolci

9:29 am

Zoltan Miskolci

Removed

Removed

9:23 am

Michael Garthwaite

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

There is one more -1 that considered D98. fp.conductivity.cmd_conductivity_sensor_filtered_readings_override()

Wednesday 11 Feb
11:33 am

Michael Garthwaite

10:10 am

Zoltan Miskolci

9:28 am

Dara Navaei

LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module
LEAHI-DIALIN-LDT-3479_D98 is in DD conductivity module
9:10 am

Michael Garthwaite

reverted handler to the original version. This was required to get a merge with develop to work

reverted handler to the original version. This was required to get a merge with develop to work

9:09 am

Michael Garthwaite

fixed.

fixed.

Tuesday 10 Feb
3:40 pm

Zoltan Miskolci

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete. Please re...

This code won't work. The sensor list missing the for loop that's populating it, and the original one is missing the M3 unpack. It's a merge of an old and a new code but both incomplete.

Please reference https://devapps.diality.us/cru/LEAHI-DIALIN-LDT-3480-1 for working solution on this.

3:34 pm

Zoltan Miskolci

Duplicate, please remove

Duplicate, please remove

Monday 09 Feb
4:20 pm

Sean Nash

Thursday 05 Feb
11:32 am

Dara Navaei

LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
LEAHI-DIALIN-LDT-3287_Dialin ability to pull B1.9 IOFP variable data has changed from B1.0
Tuesday 27 Jan
10:07 am

Michael Garthwaite

10:07 am

Michael Garthwaite

Merge branch 'staging' into LDT-2004-dialysate-composition-dd

Options
    • -8
    • +3
    ./conductivity_sensors.py
9:24 am

Zoltan Miskolci

9:20 am

Michael Garthwaite

updated to use the generic override. Both of you are correct, the generic override can be used. Since we pack the payload outside of the generic override, for this situation we don't pack the res...

updated to use the generic override.

Both of you are correct, the generic override can be used.

Since we pack the payload outside of the generic override, for this situation we don't pack the reset byte and therefore will stay as a U32 which satisfies the FW constraint. The other concern I had was that the FW would not reply back with a test ACK back to dialin with this cmd, thus causing a timeout in the generic override function. This is address as all messages in the lookup table in FW will reply back with a test ACK.

Therefore im okay using the generic override method

Monday 26 Jan
10:46 pm

Sean Nash

10:45 pm

Sean Nash

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

If Michael is right, then f/w is not expecting an override payload and so we shouldn't use the generic override payload structure.

4:51 pm

Zoltan Miskolci

4:19 pm

Vendor - TEL - Varshini Nagabooshanam and Sean Nash

3:13 pm

Zoltan Miskolci

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue. you are sending a message with this msg id and this p...

It handles different size of payloads, and requests without payload without having an issue, so I don't understand why would it cause an issue.
you are sending a message with this msg id and this payload, if the FW is expecting that, then it will work.

Should I rename the cmd_generic_override to like cmd_generic_message_sender to be less confusing?