dd-firmware / firmware / App / Modes

ModeService.c

Clone Tools

Stats

Commits this week: 0
Total Committers: 3
Last Commit: 31 Dec 69
Commits this week: 0

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 31 Jul
7:17 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
LEAHI-DD-FIRMWARE-LDT-5209_Pre-Treatment - FW Implementation - 9/6:
Wednesday 29 Jul
4:02 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
LEAHI-DD-FIRMWARE-LDT-5102_DD: Concentrate Pumps Hardware Driver Update
Wednesday 24 Jun
6:36 am

Raghu Kallala

Wednesday 06 May
8:48 am

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
LEAHI-DD-FIRMWARE-LDT-4246_FW Support for UI Demo
Tuesday 14 Apr
10:57 am

Vendor - TEL - Arpita Srivastava

Friday 10 Apr
11:38 am

Sean Nash and Vinayakam Mani

Monday 06 Apr
11:36 am

Vinayakam Mani

Balancing chamber switching control

Balancing chamber switching control

11:29 am

Vinayakam Mani

remove the space before false.

remove the space before false.

11:23 am

Vinayakam Mani

Remove blank line

Remove blank line

11:23 am

Vinayakam Mani

Remove blank line.

Remove blank line.

11:00 am

Sean Nash

10:46 am

Vendor - TEL - Arpita Srivastava

I tried the suggested change and tested. But it did not provide the expected results. If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without...

I tried the suggested change and tested. But it did not provide the expected results.
If a on was requested while an off was still pending to be processed, the off-request flag gets cleared without the actual request being processed and the off request was never executed.

Wednesday 11 Mar
2:07 pm

Sean Nash

Remove blank line and comment saying we're not doing anything (because now we're doing something).

Remove blank line and comment saying we're not doing anything (because now we're doing something).

2:05 pm

Sean Nash

isBalChamberSwitchingOffRequested is an output.

isBalChamberSwitchingOffRequested is an output.

2:03 pm

Sean Nash

Should we set the other switch to FALSE, just in case?

Should we set the other switch to FALSE, just in case?

Wednesday 25 Feb
3:31 pm

Dara Navaei

LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
LEAHI-DD-FIRMWARE-LDT-1195_DD: Request for a variable for balancing chamber switching to be active (T/F)
Friday 15 Nov 2024
1:04 pm

Vinayakam Mani

11:27 am

Dara Navaei and Sean Nash

Thursday 14 Nov 2024
3:39 pm

Vinayakam Mani

Done.

Done.

3:39 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:38 pm

Vinayakam Mani

Done.

Done.

3:37 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

3:36 pm

Vinayakam Mani

Done.

Done.

9:20 am

Sean Nash

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

Change "&&" to "||". Also, I think we need another condition added here because I don't think we should be setting all of these values if things above aren't right.

9:18 am

Sean Nash

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases. And I don't think we should be setting result to TRUE here necessarily. If we...

I don't think the "|=" is accomplishing anything useful here - this is effectively setting result to TRUE in all cases.
And I don't think we should be setting result to TRUE here necessarily. If we set result to FALSE above, it should stay FALSE.