leahi-dialin / leahi_dialin / td

treatment_delivery.py

Clone Tools

Stats

Commits this week: 6
Total Committers: 5
Last Commit: 31 Dec 69
Commits this week: 6

Lines of code count not available

Commit Activity

Commits By Day In Week
52 week commits volume
Commits By Day In Week
Commits by day
Commits By Day In Week
Commits by hour
Commits By Hour In Day
Commit calendar
 

Most active committers (90 days)

loading
loading
  • last updated a few seconds ago
All Commits Reviews
Constraints
Constraints: committers
 
Constraints: files
Constraints: dates
Friday 07 Aug
3:49 pm

Zoltan Miskolci

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update. For more ...

No need, in a different CR I have a module that pulls the Alarm ID, Reject Reason and Msg Ids directly from the FW. After that's merged, this file won't be needed any more manual update.

For more information check LDT-5205 CR, file: utils\ enum_updater.py

Thursday 06 Aug
10:21 pm

Michael Garthwaite

10:10 pm

Michael Garthwaite

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

In FW we pre-populated Alarm IDs up to 300 to help with the reservation process. Would this also benefit dialin if we reserve up to 300?

2:38 pm

Zoltan Miskolci

Wrong MsgID Update the entity name too

Wrong MsgID
Update the entity name too

2:38 pm

Zoltan Miskolci

Wrong MsgID Update the entity name too

Wrong MsgID
Update the entity name too

2:37 pm

Zoltan Miskolci

Update header

Update header

2:36 pm

Zoltan Miskolci

Update header

Update header

2:36 pm

Zoltan Miskolci

.name Use the name as key, to match the above suggested changes

.name

Use the name as key, to match the above suggested changes

2:35 pm

Zoltan Miskolci

.name Use the name instead of the full enum for key

.name
Use the name instead of the full enum for key

2:34 pm

Zoltan Miskolci

import from msg_ids, because the enum located there not in msg_defs

import from msg_ids, because the enum located there not in msg_defs

2:34 pm

Zoltan Miskolci

Update

Update

2:33 pm

Zoltan Miskolci

Align the values please

Align the values please

2:32 pm

Zoltan Miskolci

Conflicting with existing ones

Conflicting with existing ones

Wednesday 05 Aug
3:02 pm

Zoltan Miskolci

8:34 am

Michael Garthwaite

Friday 31 Jul
10:18 am

Dara Navaei

LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
LEAHI-DIALIN-LDT-5205_[DD] Update NVM records architecture in Dialin
Wednesday 29 Jul
8:13 pm

Vendor - TEL - Suresh Dharnala

5:03 pm

Zoltan Miskolci

3:20 pm

Raghu Kallala

Tuesday 21 Jul
9:52 am

Vendor - TEL - Arpita Srivastava

7:29 am

Raghu Kallala

Monday 20 Jul
12:34 pm

Dara Navaei

LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor
LEAHI-DIALIN-LDT-5152_[Dialin] Handler architecture refactor
Wednesday 15 Jul
3:04 pm

Dara Navaei

LEAHI-DIALIN-LDT-4611_HDF - FW Implementation - 5/4:
LEAHI-DIALIN-LDT-4611_HDF - FW Implementation - 5/4:
Monday 13 Jul
2:46 pm

Tiffany Mejia and Michael Garthwaite

11:51 am

Zoltan Miskolci

Sunday 12 Jul
11:44 pm

Behrouz NematiPour

Zoltan and I had a meeting, and the counter solution he provided works better than mine. He explained to me that my proposed solution has flaws. RESOLVED.

Zoltan and I had a meeting, and the counter solution he provided works better than mine.
He explained to me that my proposed solution has flaws.
RESOLVED.

Friday 10 Jul
11:45 am

Tiffany Mejia and Michael Garthwaite

Monday 06 Jul
12:55 pm

Sean Nash

Wednesday 01 Jul
3:02 pm

Zoltan Miskolci

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility. 1. The conversion module's bytearray to value methods work, but th...

The approach of what this code does and the conversion module are similar in function but a differ on maintenance and flexibility.
1. The conversion module's bytearray to value methods work, but they require manual logistic around the indexing. It's the user's responsibility to handle where the reading starts and you need to code the handler for that (previous approach with MsgFieldPositions), It's inflating the method. I worked hard to remove the need for indexing where the value starts. Instead of the previous struct.unpack approach, where you needed to maintain the type, you will be needing to maintain the conversion methods that are being called, so it would be the same as before, you still need to mind the indexing, which was the main reason of changing from this approach.

2. In the current approach, you declare the type and pass it to a processor that dynamically handling the unpack type (based on the set datatype) and the indexing for that. This works much better and easier to maintain, as you can just insert a new value when it's added to the FW, and don't need to adjust all your indexes for the reading.

Example #1, changing build type from U16 to U08:

  • with the conversion approach, you need to change the function used, and update the starting index for all the following methods.
  • with the current approach you change the Datatype.U16 to Datatype.U08 and that's all you need to do.


Example #2: adding a new variable fpga_micro after fpga_minor, with U08 type:

  • with the conversion approach, you add the bytearray_to_byte, update the indexes for all the following reads.
  • with the current approach you insert an element after the fpga_minor with a value ('fpga_micro', Datatype.U08), and nothing more needed
12:33 pm

Behrouz NematiPour

RESOLVED for now.

RESOLVED for now.